From: Manfred Spraul <manfred@colorfullife.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, colpatch@us.ibm.com
Subject: Re: [PATCH 3/5] slab: extract slabinfo header printing to separate function
Date: Sat, 19 Nov 2005 13:11:11 +0100 [thread overview]
Message-ID: <437F165F.80203@colorfullife.com> (raw)
In-Reply-To: <iq5uuc.zmsv6.a6p8qowodnwx9kaa8jonhv8n3.beaver@cs.helsinki.fi>
Pekka Enberg wrote:
> #ifdef CONFIG_PROC_FS
>
>-static void *s_start(struct seq_file *m, loff_t *pos)
>+static inline void print_slabinfo_header(struct seq_file *m)
>
>
Why inline? I try to avoid adding inline wherever possible. inline is
actually always_inline force_inline
compiler_we_know_it_better_this_must_be_inlined.
I only use inline in the hot path (kmem_cache_alloc/kmalloc+free) and
where I know that lots of code will be optimized away due to constant
propagation. In this case, there is no reason to force the compiler to
inline the function, thus I wouldn't add an inline.
--
Manfred
next prev parent reply other threads:[~2005-11-19 12:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 17:20 [PATCH 1/5] slab: rename obj_reallen to obj_size Pekka Enberg
2005-11-18 17:20 ` [PATCH 2/5] slab: remove unused align parameter from alloc_percpu Pekka Enberg
2005-11-18 17:20 ` [PATCH 3/5] slab: extract slabinfo header printing to separate function Pekka Enberg
2005-11-18 17:20 ` [PATCH 4/5] slab: extract slab order calculation " Pekka Enberg
2005-11-18 17:20 ` [PATCH 5/5] slab: fix code formatting Pekka Enberg
2005-11-19 12:25 ` [PATCH 4/5] slab: extract slab order calculation to separate function Manfred Spraul
2005-11-19 17:33 ` Andrew Morton
2005-11-19 12:11 ` Manfred Spraul [this message]
2005-11-19 12:20 ` [PATCH 3/5] slab: extract slabinfo header printing " Pekka Enberg
2005-11-19 12:00 ` [PATCH 2/5] slab: remove unused align parameter from alloc_percpu Manfred Spraul
2005-11-19 11:57 ` [PATCH 1/5] slab: rename obj_reallen to obj_size Manfred Spraul
2005-11-19 12:04 ` Pekka Enberg
2005-11-19 12:34 ` Manfred Spraul
2005-11-19 12:37 ` Pekka Enberg
2005-11-19 12:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437F165F.80203@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox