From: Bill Davidsen <davidsen@tmr.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Ashutosh Naik <ashutosh.lkml@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Over-riding symbols in the Kernel causes Kernel Panic
Date: Wed, 23 Nov 2005 14:08:42 -0500 [thread overview]
Message-ID: <4384BE3A.6060505@tmr.com> (raw)
In-Reply-To: <9a8748490511231004l36edcf57mf0fb63c4a9e17f49@mail.gmail.com>
Jesper Juhl wrote:
> On 11/23/05, Bill Davidsen <davidsen@tmr.com> wrote:
>
>>Ashutosh Naik wrote:
>>
>>>Hi,
>>>
>>>I made e1000 ( or for that matter anything) a part of the 2.6.15-rc1
>>>kernel and booted the kernel. Next I compiled e1000 as a module (
>>>e1000.ko ), and tried to insmod it into the kernel( which already had
>>>e1000 a compiled as a part of the kernel). I observed that
>>>/proc/kallsyms contained two copies of all the symbols exported by
>>>e1000, and I also got a Kernel Panic on the way.
>>>
>>>Is this behaviour natural and desirable ?
>>
>>No, trying to insert a module into a kernel built with the functionality
>>compiled in is a vile perverted act, and probably illegal in Republican
>>states! ;-)
>>
>>The other day I mentioned that reiser4 will find bugs because people
>>will do bizarre things with it when it is more widely used. I think you
>>have hit a "no one would ever do that" bug in the module loader, and
>>demonstrated my point in the process.
>>
>>The panic isn't desirable, but I'm not sure what "correct behaviour"
>>would be, I can't imagine that this is intended to work. The issues of
>>removing such a module gracefully are significant.
>
>
> Wouldn't the desired behaviour be that when the kernel attempts to
> load a module it checks if it is already present build-in and if so
> simply refuse to load it at all?
It doesn't look to be quite as easy to check for built-in as to check
for "already loaded" without some global state tracking, and handling
the case where it just wasn't built at all, and may have other stuff
missing. Add to this not breaking existing out of tree code and the
implementation looks like a non-trivial exercise.
--
-bill davidsen (davidsen@tmr.com)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me
next prev parent reply other threads:[~2005-11-28 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 14:10 Over-riding symbols in the Kernel causes Kernel Panic Ashutosh Naik
2005-11-23 14:22 ` linux-os (Dick Johnson)
2005-11-23 17:46 ` Bill Davidsen
2005-11-23 18:04 ` Jesper Juhl
2005-11-23 19:08 ` Bill Davidsen [this message]
2005-11-30 14:00 ` Ashutosh Naik
2005-11-23 21:07 ` Grant Coady
2005-11-23 21:21 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4384BE3A.6060505@tmr.com \
--to=davidsen@tmr.com \
--cc=ashutosh.lkml@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox