From: Mark Lord <lkml@rtr.ca>
To: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.6.15-rc2] b44: missing netif_wake_queue() in b44_open()
Date: Thu, 24 Nov 2005 14:43:26 -0500 [thread overview]
Message-ID: <438617DE.5000700@rtr.ca> (raw)
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
This patch fixes a problem plaguing Dell notebooks with
built-in b44 ethernet: The driver refuses to transmit packets
of any kind until after the first 5-second tx_timeout occurs.
This bug causes DHCP negotiation to fail (timeout) during
installation of Ubuntu Linux.
One-liner fix. Please review (and apply if you like it).
Signed-off-by: Mark Lord <lkml@rtr.ca>
--- linux-2.6.15-rc2/drivers/net/b44.c 2005-11-19 22:25:03.000000000 -0500
+++ linux/drivers/net/b44.c 2005-11-24 14:28:47.000000000 -0500
@@ -1417,6 +1417,7 @@
add_timer(&bp->timer);
b44_enable_ints(bp);
+ netif_wake_queue(dev); /* prevent the initial tx_timeout() we otherwise see */
out:
return err;
}
[-- Attachment #2: b44_fix.patch --]
[-- Type: text/x-patch, Size: 315 bytes --]
--- linux-2.6.15-rc2/drivers/net/b44.c 2005-11-19 22:25:03.000000000 -0500
+++ linux/drivers/net/b44.c 2005-11-24 14:28:47.000000000 -0500
@@ -1417,6 +1417,7 @@
add_timer(&bp->timer);
b44_enable_ints(bp);
+ netif_wake_queue(dev); /* prevent the initial tx_timeout() we otherwise see */
out:
return err;
}
next reply other threads:[~2005-11-24 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-24 19:43 Mark Lord [this message]
[not found] ` <Pine.LNX.4.64.0511241146560.13959@g5.osdl.org>
[not found] ` <43861E6F.9090604@pobox.com>
2005-11-24 20:27 ` [PATCH 2.6.15-rc2] b44: missing netif_wake_queue() in b44_open() Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438617DE.5000700@rtr.ca \
--to=lkml@rtr.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox