From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Junsu Shin <jjunes0@gmail.com>
Cc: mchehab@osg.samsung.com, hans.verkuil@cisco.com,
prabhakar.csengg@gmail.com, sakari.ailus@linux.intel.com,
mahfouz.saif.elyazal@gmail.com,
boris.brezillon@free-electrons.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue
Date: Mon, 09 Nov 2015 22:56:14 +0200 [thread overview]
Message-ID: <43865783.PsqqNIiBss@avalon> (raw)
In-Reply-To: <1439242859-12268-1-git-send-email-jjunes0@gmail.com>
Hello Junsu,
Thank you for the patch.
On Monday 10 August 2015 16:40:59 Junsu Shin wrote:
> This is a patch to the dm365_ipipe.c that fixes over 80 characters warning
> detected.
It's a bit ironic to submit a patch fixing a 80 characters limit issue and
having a commit message that is larger than 72 characters per line :-)
Anyway, I've wrapped the commit message to 72 columns and applied the patch to
my tree.
> Signed-off-by: Junsu Shin <jjunes0@gmail.com>
> ---
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..a474adf
> 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct
> v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum
> structure.
> */
> static int
> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config
> *cfg, - struct v4l2_subdev_frame_size_enum *fse)
> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_frame_size_enum *fse)
> {
> struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
> struct v4l2_mbus_framefmt format;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-11-09 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 21:40 [PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue Junsu Shin
2015-11-09 20:56 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43865783.PsqqNIiBss@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=boris.brezillon@free-electrons.com \
--cc=hans.verkuil@cisco.com \
--cc=jjunes0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox