From: Oleg Nesterov <oleg@tv-sign.ru>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: [PATCH 1/2] v2 PF_DEAD: cleanup usage
Date: Fri, 25 Nov 2005 19:18:08 +0300 [thread overview]
Message-ID: <43873940.71D85208@tv-sign.ru> (raw)
schedule() checks PF_DEAD on every context switch, and sets ->state = EXIT_DEAD
to ensure that exited task will be deactivated.
It is possible to set new ->state value in do_exit(), along with PF_DEAD flag,
and remove the check from schedule()'s hot path.
To avoid mixing ->state/->exit_state values, this patch adds new TASK_DEAD state.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.15-rc2/include/linux/sched.h~1_CLEAN 2005-11-25 20:58:09.000000000 +0300
+++ 2.6.15-rc2/include/linux/sched.h 2005-11-25 21:02:22.000000000 +0300
@@ -127,6 +127,7 @@ extern unsigned long nr_iowait(void);
#define EXIT_DEAD 32
/* in tsk->state again */
#define TASK_NONINTERACTIVE 64
+#define TASK_DEAD 128
#define __set_task_state(tsk, state_value) \
do { (tsk)->state = (state_value); } while (0)
--- 2.6.15-rc2/kernel/exit.c~1_CLEAN 2005-11-25 20:58:14.000000000 +0300
+++ 2.6.15-rc2/kernel/exit.c 2005-11-25 21:04:26.000000000 +0300
@@ -875,6 +875,7 @@ fastcall NORET_TYPE void do_exit(long co
preempt_disable();
BUG_ON(tsk->flags & PF_DEAD);
tsk->flags |= PF_DEAD;
+ tsk->state = TASK_DEAD;
schedule();
BUG();
--- 2.6.15-rc2/kernel/sched.c~1_CLEAN 2005-11-25 20:58:14.000000000 +0300
+++ 2.6.15-rc2/kernel/sched.c 2005-11-25 21:04:48.000000000 +0300
@@ -3000,9 +3000,6 @@ need_resched_nonpreemptible:
spin_lock_irq(&rq->lock);
- if (unlikely(prev->flags & PF_DEAD))
- prev->state = EXIT_DEAD;
-
switch_count = &prev->nivcsw;
if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
switch_count = &prev->nvcsw;
reply other threads:[~2005-11-25 15:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43873940.71D85208@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox