public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Michael Krufky <mkrufky@m1k.net>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.15-rc3
Date: Tue, 29 Nov 2005 18:43:17 +1100	[thread overview]
Message-ID: <438C0695.2050808@yahoo.com.au> (raw)
In-Reply-To: <438C0124.3030700@m1k.net>

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Michael Krufky wrote:

> Unable to handle kernel NULL pointer dereference at virtual address 

> EFLAGS: 00010202   (2.6.15-rc3) EIP is at vm_normal_page+0x17/0x60

> Process gdb (pid: 5628, threadinfo=f488e000 task=f7239a30)

> [<c014a8f5>] get_user_pages+0x29f/0x309

The clues point to the following patch. Can you give it a test
please?

Thanks,
Nick

-- 
SUSE Labs, Novell Inc.


[-- Attachment #2: mm-fix-oops.patch --]
[-- Type: text/plain, Size: 693 bytes --]

vm_normal_page can be called with a NULL vma. This can be replaced with
gate_vma, and no problem because none of the gate vmas use VM_PFNMAP
(if they did they would need to set vm_pgoff).

Signed-off-by: Nick Piggin <npiggin@suse.de>

Index: linux-2.6/mm/memory.c
===================================================================
--- linux-2.6.orig/mm/memory.c
+++ linux-2.6/mm/memory.c
@@ -988,7 +988,8 @@ int get_user_pages(struct task_struct *t
 				return i ? : -EFAULT;
 			}
 			if (pages) {
-				struct page *page = vm_normal_page(vma, start, *pte);
+				struct page *page;
+				page = vm_normal_page(gate_vma, start, *pte);
 				pages[i] = page;
 				if (page)
 					get_page(page);

  reply	other threads:[~2005-11-29  7:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-29  4:11 Linux 2.6.15-rc3 Linus Torvalds
2005-11-29  7:20 ` Michael Krufky
2005-11-29  7:43   ` Nick Piggin [this message]
2005-11-29  8:25     ` Michael Krufky
2005-11-29 15:47     ` Linus Torvalds
2005-11-29 16:10   ` Linus Torvalds
2005-11-29 16:25     ` Michael Krufky
2005-11-29 16:38       ` Linus Torvalds
2005-11-29 16:49         ` Stephen Frost
2005-11-29 17:04           ` Michael Krufky
2005-11-30  0:18           ` David S. Miller
2005-11-29 17:25         ` Chris Shoemaker
2005-11-29 17:44           ` Stephen Frost
2005-11-29 18:37           ` Linux 2.6.15-rc3 - gcc-4.0.2 compile error Byron Stanoszek
2005-11-29 18:42             ` Arjan van de Ven
2005-11-30  5:53           ` Linux 2.6.15-rc3 Michael Krufky
2005-11-29  9:29 ` Linux 2.6.15-rc3 - VIDEO_BT848_DVB config Eyal Lebedinsky
2005-11-29 13:07   ` Michael Krufky
2005-11-29 21:36 ` Linux 2.6.15-rc3 Helge Hafting
2005-11-29 21:47   ` Linus Torvalds
2005-11-30  8:59     ` Helge Hafting
2005-12-01  8:16       ` Jeff Garzik
2005-12-01  9:32         ` Helge Hafting
2005-12-01  9:37           ` Jeff Garzik
2005-12-04  0:43         ` Linux 2.6.15-rc3 problem found - scsi order changed Helge Hafting
2005-12-04  1:14           ` Linus Torvalds
2005-12-04  9:34             ` Zwane Mwaikambo
2005-12-04 15:28               ` Adrian Bunk
2005-12-04 23:50               ` Helge Hafting
2005-11-29 21:47 ` Linux 2.6.15-rc3 Rafael J. Wysocki
2005-11-29 22:42   ` Rafael J. Wysocki
2005-11-29 22:53     ` Stephen Hemminger
2005-11-29 23:37       ` Greg KH
2005-11-30  0:17         ` Stephen Hemminger
2005-11-30  0:25           ` Andrew Morton
2005-11-30  0:42             ` Stephen Hemminger
2005-11-30  1:57               ` Linus Torvalds
2005-11-30  2:09                 ` Paul Mackerras
2005-11-30  2:46                 ` Stephen Hemminger
2005-11-30  3:16                   ` Linus Torvalds
2005-11-30  4:14                     ` Greg KH
2005-11-30  1:09         ` Stephen Hemminger
2005-11-30  6:11   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438C0695.2050808@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@m1k.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox