From: Thomas Winischhofer <thomas@winischhofer.net>
To: Greg KH <greg@kroah.com>
Cc: Adrian Bunk <bunk@stusta.de>,
gregkh@suse.de, linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/usb/misc/sisusbvga/sisusb.c: remove dead code
Date: Tue, 29 Nov 2005 11:25:00 +0100 [thread overview]
Message-ID: <438C2C7C.1020004@winischhofer.net> (raw)
In-Reply-To: <20051128205220.GE17740@kroah.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Greg KH wrote:
> On Wed, Nov 23, 2005 at 09:31:50PM +0100, Adrian Bunk wrote:
>
>>On Wed, Nov 23, 2005 at 11:02:37AM -0800, Greg KH wrote:
>>
>>>On Mon, Nov 21, 2005 at 12:22:39AM +0100, Adrian Bunk wrote:
>>>
>>>>The Coverity checker found this obviously dead code.
>>>
>>>I think the checker is wrong, this does not look correct to me.
>>
>>Why?
>>
>>Due to the while(length), length can't be 0 at the switch.
>
>
> Doh, ok, nevermind. Care to resend this?
Took me also a few seconds to realize that the tool is correct. Nice stuff.
Thomas
- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net *** http://www.winischhofer.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDjCx8zydIRAktyUcRAi8NAKCA96Bt9ibOIRGQWhSUy6qnd5QxYwCeLtHE
VvGqTMgnn476dnm/PYKBSM8=
=3eHZ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2005-11-29 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 23:22 [2.6 patch] drivers/usb/misc/sisusbvga/sisusb.c: remove dead code Adrian Bunk
2005-11-23 19:02 ` Greg KH
2005-11-23 20:31 ` Adrian Bunk
2005-11-28 20:52 ` Greg KH
2005-11-29 10:25 ` Thomas Winischhofer [this message]
2005-11-29 13:01 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438C2C7C.1020004@winischhofer.net \
--to=thomas@winischhofer.net \
--cc=bunk@stusta.de \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox