From: Jari Ruusu <jariruusu@users.sourceforge.net>
To: Benjamin LaHaise <bcrl@kvack.org>, Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] x86-64 put current in r10
Date: Wed, 30 Nov 2005 08:39:01 +0200 [thread overview]
Message-ID: <438D4905.9F023405@users.sourceforge.net> (raw)
In-Reply-To: 20051130042118.GA19112@kvack.org
Benjamin LaHaise wrote:
> The following emails contain the patches to convert x86-64 to store current
> in r10 (also at http://www.kvack.org/~bcrl/patches/v2.6.15-rc3/).
[snip]
> No benchmarks that I am aware of show regressions with this change.
Ben,
Your patch breaks all out-of-tree amd64 assembler code used in kernel. r10
register is one of those registers that does not need to be preserved across
function calls, and reserving that register for other purpose means that all
assembler code using r10 in kernel must be rewritten. This is deeply
unfunny.
Andi,
Please don't apply Ben's patch. It is already bad enough having to deal with
two incompatible calling conventions on 32 bit x86.
--
Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD
next prev parent reply other threads:[~2005-11-30 6:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-30 4:21 [PATCH 0/9] x86-64 put current in r10 Benjamin LaHaise
2005-11-30 6:39 ` Jari Ruusu [this message]
2005-11-30 7:56 ` Arjan van de Ven
2005-11-30 8:20 ` Nick Piggin
2005-11-30 17:29 ` Jari Ruusu
2005-11-30 17:32 ` Andi Kleen
2005-11-30 17:33 ` Christoph Hellwig
2005-11-30 12:45 ` Andi Kleen
2005-11-30 16:22 ` Randy.Dunlap
2005-11-30 16:39 ` Kyle Moffett
2005-12-01 9:06 ` Helge Hafting
2005-11-30 13:02 ` Andi Kleen
2005-11-30 13:32 ` Arjan van de Ven
2005-11-30 15:10 ` Benjamin LaHaise
2005-11-30 13:57 ` Andi Kleen
2005-11-30 15:18 ` Matti Aarnio
2005-11-30 15:24 ` Benjamin LaHaise
2005-11-30 15:29 ` Andi Kleen
2005-11-30 15:34 ` Arjan van de Ven
2005-11-30 16:13 ` Jesper Juhl
2005-12-01 14:30 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438D4905.9F023405@users.sourceforge.net \
--to=jariruusu@users.sourceforge.net \
--cc=ak@suse.de \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox