public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Andrew Morton <akpm@osdl.org>, Adam Litke <agl@us.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Fix handling of ELF segments with zero filesize
Date: Wed, 30 Nov 2005 16:26:18 -0800	[thread overview]
Message-ID: <438E432A.2010304@zytor.com> (raw)
In-Reply-To: <20051201002049.GB14247@localhost.localdomain>

David Gibson wrote:
> Andrew, please apply
> 
> mmap() returns -EINVAL if given a zero length, and thus elf_map() in
> binfmt_elf.c does likewise if it attempts to map a (page-aligned) ELF
> segment with zero filesize.  Such a situation never arises with the
> default linker scripts, but there's nothing inherently wrong with
> zero-filesize (but non-zero memsize) ELF segments.  Custom linker
> scripts can generate them, and the kernel should be able to map them;
> this patch makes it so.
> 

More than that: even with some versions of the default linker scripts 
they can be created, according to reports I have received on the klibc 
mailing list.  It just doesn't happen with glibc binaries.

This is a real bug and should be fixed.

	-hpa

  reply	other threads:[~2005-12-01  0:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-01  0:20 Fix handling of ELF segments with zero filesize David Gibson
2005-12-01  0:26 ` H. Peter Anvin [this message]
2005-12-01  5:26 ` Willy Tarreau
2005-12-01  5:36   ` David Gibson
2005-12-01  5:45     ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438E432A.2010304@zytor.com \
    --to=hpa@zytor.com \
    --cc=agl@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox