* [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason
@ 2005-11-11 12:56 Gabriel A. Devenyi
2005-12-01 7:39 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-11 12:56 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
current definition.
Thanks to LinuxICC (http://linuxicc.sf.net).
This patch applies to linus' git tree as of 03.11.2005
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 750c016..849ac88 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
return 1;
}
-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
{
u16 status;
--
Gabriel A. Devenyi
ace@staticwave.ca
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason
2005-11-11 12:56 [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason Gabriel A. Devenyi
@ 2005-12-01 7:39 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2005-12-01 7:39 UTC (permalink / raw)
To: Gabriel A. Devenyi; +Cc: linux-kernel, akpm
Gabriel A. Devenyi wrote:
> fid is declared as a u32 (unsigned int), and then a few lines later, it
> is checked for a value < 0, which is clearly useless.
> In the two locations this function is used, in one it is *explicitly*
> given a negative number, which would be ignored with the
> current definition.
>
> Thanks to LinuxICC (http://linuxicc.sf.net).
>
> This patch applies to linus' git tree as of 03.11.2005
>
> Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'drivers/net/wireless/airo.c unsigned comparason'
fatal: corrupt patch at line 8
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason
@ 2005-11-08 12:39 Gabriel A. Devenyi
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-08 12:39 UTC (permalink / raw)
To: linux-kernel; +Cc: kernel-janitors
fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
current definition.
Thanks to LinuxICC (http://linuxicc.sf.net).
This patch applies to linus' git tree as of 03.11.2005
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 750c016..849ac88 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
return 1;
}
-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
{
u16 status;
--
Gabriel A. Devenyi
ace@staticwave.ca
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-01 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-11 12:56 [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason Gabriel A. Devenyi
2005-12-01 7:39 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-11-08 12:39 Gabriel A. Devenyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox