public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* MTD: fix possible starvation in cfi_cmdset_0001.c
@ 2005-12-02 21:04 Thomas Gall
  0 siblings, 0 replies; only message in thread
From: Thomas Gall @ 2005-12-02 21:04 UTC (permalink / raw)
  To: linux-kernel

The patch below fixes a potential starvation issue that can arise when
there is contention on a chip during a period when a process is
currently writing to it.  The starvation is avoided by conditionally
rescheduling when the chip is left in a state usable by other processes.

Please CC Josh and myself and replies.  Thanks!

Signed-off-by: Josh Boyer <jdub@us.ibm.com>
Signed-off-by: Tom Gall <tom_gall@vnet.ibm.com>

 drivers/mtd/chips/cfi_cmdset_0001.c |    5 +++++
 1 files changed, 5 insertions(+)

Index: mtd/drivers/mtd/chips/cfi_cmdset_0001.c
===================================================================
--- mtd.orig/drivers/mtd/chips/cfi_cmdset_0001.c	2005-11-07 15:04:33.000000000 -0600
+++ mtd/drivers/mtd/chips/cfi_cmdset_0001.c	2005-11-08 08:54:54.000000000 -0600
@@ -1695,6 +1695,11 @@ static int cfi_intelext_writev (struct m
 			if (chipnum == cfi->numchips)
 				return 0;
 		}
+
+		/* Be nice and reschedule with the chip in a usable state for other
+		   processes. */
+		cond_resched();
+
 	} while (len);

 	return 0;

-- 
Linux Technology Center
Senior Software Engineer, - Embedded Linux                                              
w) tom_gall@vnet.ibm.com    553-4558
h) tgall@uberh4x0r.org
"We want great men who, when fortune frowns, will not be discouraged." 
-- Colonel Henry Knox


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-12-02 21:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-02 21:04 MTD: fix possible starvation in cfi_cmdset_0001.c Thomas Gall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox