public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	myungjoo.ham@samsung.com, cw00.choi@samsung.com,
	devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: [PATCH] extcon-usb-gpio: add enable pin support
Date: Fri, 11 Dec 2015 02:07:05 +0300	[thread overview]
Message-ID: <4393960.B6dD3UkQy3@wasted.cogentembedded.com> (raw)

Sometimes  there's a real  OTG chip behind the USB ID signal mapped to a GPIO
pin: in my case it's Maxim Integrated MAX3355E which  integrates Vbus charge
pump and comparators and passes  thru the ID  signal  from an OTG connector.
This chip also has the SHDN# pin which  should be  driven high for the normal
operation  and low to  save power;  it  is connected to a GPIO pin as well on,
hence  we'll have  to  teach the driver to parse the new optional device tree
property, "enable-gpio"...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'extcon-next' branch of the 'extcon.git' repo.

 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt |    3 +++
 drivers/extcon/extcon-usb-gpio.c                             |    5 +++++
 2 files changed, 8 insertions(+)

Index: extcon/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
===================================================================
--- extcon.orig/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
+++ extcon/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
@@ -7,6 +7,9 @@ Required properties:
 - compatible: Should be "linux,extcon-usb-gpio"
 - id-gpio: gpio for USB ID pin. See gpio binding.
 
+Optional properties:
+- enable-gpio: gpio for the enable pin. See gpio binding.
+
 Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
 	extcon_usb1 {
 		compatible = "linux,extcon-usb-gpio";
Index: extcon/drivers/extcon/extcon-usb-gpio.c
===================================================================
--- extcon.orig/drivers/extcon/extcon-usb-gpio.c
+++ extcon/drivers/extcon/extcon-usb-gpio.c
@@ -33,6 +33,7 @@ struct usb_extcon_info {
 	struct device *dev;
 	struct extcon_dev *edev;
 
+	struct gpio_desc *enable_gpiod;
 	struct gpio_desc *id_gpiod;
 	int id_irq;
 
@@ -99,6 +100,8 @@ static int usb_extcon_probe(struct platf
 		return -ENOMEM;
 
 	info->dev = dev;
+	info->enable_gpiod = devm_gpiod_get_optional(&pdev->dev, "enable",
+						     GPIOD_OUT_HIGH);
 	info->id_gpiod = devm_gpiod_get(&pdev->dev, "id", GPIOD_IN);
 	if (IS_ERR(info->id_gpiod)) {
 		dev_err(dev, "failed to get ID GPIO\n");
@@ -155,6 +158,8 @@ static int usb_extcon_remove(struct plat
 
 	cancel_delayed_work_sync(&info->wq_detcable);
 
+	gpiod_set_value_cansleep(info->enable_gpiod, 0);
+
 	return 0;
 }
 


             reply	other threads:[~2015-12-10 23:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 23:07 Sergei Shtylyov [this message]
2015-12-11  3:53 ` [PATCH] extcon-usb-gpio: add enable pin support Rob Herring
2015-12-11 18:33   ` Sergei Shtylyov
2015-12-11  4:05 ` Chanwoo Choi
2015-12-11 14:44   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4393960.B6dD3UkQy3@wasted.cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox