From: Olivier MATZ <zer0@droids-corp.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] asm-i386 : config.h should not be included out of kernel
Date: Tue, 06 Dec 2005 21:26:45 +0100 [thread overview]
Message-ID: <4395F405.9010107@droids-corp.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
Hi,
It seems that in include/asm-i386/param.h the "#include
<linux/config.h>" should be inside the #ifdef __KERNEL__, as it is done
in asm-ia64.
Some applications cannot compile/work correctly whithout this patch. For
example busybox defines for itself CONFIG_TR (related to the tr
program), which is unfortunately undefined when including sys/param.h,
which includes linux/config.h (CONFIG_TR is the config for token ring).
Can you consider the following patch ?
Thanks,
Olivier
[-- Attachment #2: asm-i386_dont_include_config.diff --]
[-- Type: text/plain, Size: 566 bytes --]
--- linux-2.6.14.3.orig/include/asm-i386/param.h 2005-12-06 14:13:15.000000000 +0100
+++ linux-2.6.14.3/include/asm-i386/param.h 2005-12-06 13:51:12.000000000 +0100
@@ -1,9 +1,9 @@
-#include <linux/config.h>
-
#ifndef _ASMi386_PARAM_H
#define _ASMi386_PARAM_H
#ifdef __KERNEL__
+#include <linux/config.h> /* mustn't include <linux/config.h> outside of #ifdef __KERNEL__ */
+
# define HZ CONFIG_HZ /* Internal kernel timer frequency */
# define USER_HZ 100 /* .. some user interfaces are in "ticks" */
# define CLOCKS_PER_SEC (USER_HZ) /* like times() */
next reply other threads:[~2005-12-06 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 20:26 Olivier MATZ [this message]
2005-12-06 21:11 ` [PATCH] asm-i386 : config.h should not be included out of kernel Arnd Bergmann
2005-12-07 17:28 ` Olivier MATZ
2005-12-07 19:10 ` Sam Ravnborg
2005-12-07 20:02 ` Andrew Walrond
2005-12-07 20:09 ` Olivier MATZ
2005-12-07 21:32 ` Sam Ravnborg
2005-12-08 11:33 ` Olivier MATZ
2005-12-08 17:39 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4395F405.9010107@droids-corp.org \
--to=zer0@droids-corp.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox