From: Shailabh Nagar <nagar@watson.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
elsa-devel <elsa-devel@lists.sourceforge.net>,
LSE <lse-tech@lists.sourceforge.net>,
ckrm-tech <ckrm-tech@lists.sourceforge.net>,
Guillaume Thouvenin <guillaume.thouvenin@bull.net>,
Jay Lan <jlan@sgi.com>, Jens Axboe <axboe@suse.de>,
Suparna Bhattacharya <bsuparna@in.ibm.com>
Subject: Re: [ckrm-tech] [RFC][Patch 3/5] Per-task delay accounting: Sync block I/O delays
Date: Wed, 07 Dec 2005 23:06:37 +0000 [thread overview]
Message-ID: <43976AFD.7020707@watson.ibm.com> (raw)
In-Reply-To: <1133994835.30387.49.camel@localhost>
Dave Hansen wrote:
> On Wed, 2005-12-07 at 22:23 +0000, Shailabh Nagar wrote:
>
>>+ if (-EIOCBQUEUED == ret) {
>>+ __attribute__((unused)) struct timespec start, end;
>>+
>
>
> Those "unused" things suck. They're really ugly.
>
> Doesn't making your delay functions into static inlines make the unused
> warnings go away?
They do indeed. Thanks !
It was a holdover from when the delay funcs were macros. Will fix everywhere.
--Shailabh
>
> -- Dave
next prev parent reply other threads:[~2005-12-07 23:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 22:08 [RFC][Patch 0/5] Per-task delay accounting Shailabh Nagar
2005-12-07 22:13 ` [RFC][Patch 1/5] nanosecond timestamps and diffs Shailabh Nagar
2005-12-12 18:50 ` [Lse-tech] " Christoph Lameter
2005-12-12 19:31 ` Shailabh Nagar
2005-12-12 19:49 ` john stultz
2005-12-12 20:00 ` Shailabh Nagar
2005-12-12 20:07 ` john stultz
2005-12-13 0:54 ` George Anzinger
2005-12-13 3:48 ` Nish Aravamudan
2005-12-13 18:35 ` Jay Lan
2005-12-13 21:16 ` john stultz
2005-12-13 21:44 ` Shailabh Nagar
2005-12-13 22:13 ` George Anzinger
2005-12-13 23:05 ` [ckrm-tech] " Matt Helsley
2005-12-07 22:15 ` [RFC][Patch 2/5] Per-task delay accounting: Initialization, dynamic turn on/off Shailabh Nagar
2005-12-07 22:23 ` [RFC][Patch 3/5] Per-task delay accounting: Sync block I/O delays Shailabh Nagar
2005-12-07 22:33 ` [ckrm-tech] " Dave Hansen
2005-12-07 23:06 ` Shailabh Nagar [this message]
2005-12-07 22:28 ` [RFC][Patch 4/5] Per-task delay accounting: Swap in delays Shailabh Nagar
2005-12-07 22:29 ` [RFC][Patch 5/5] Per-task delay accounting: procfs interface Shailabh Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43976AFD.7020707@watson.ibm.com \
--to=nagar@watson.ibm.com \
--cc=axboe@suse.de \
--cc=bsuparna@in.ibm.com \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=elsa-devel@lists.sourceforge.net \
--cc=guillaume.thouvenin@bull.net \
--cc=haveblue@us.ibm.com \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox