From: Nick Piggin <piggin@cyberone.com.au>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
lhms-devel@lists.sourceforge.net
Subject: Re: [PATCH] swap migration: Fix lru drain
Date: Thu, 08 Dec 2005 11:59:41 +1100 [thread overview]
Message-ID: <4397857D.8040604@cyberone.com.au> (raw)
In-Reply-To: <Pine.LNX.4.62.0512071641080.26288@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
>On Thu, 8 Dec 2005, Nick Piggin wrote:
>
>
>>Do we need a lock_cpu_hotplug() around here?
>>
>
>Well, then we may need that lock for each "for_each_online_cpu" use?
>
I think it depends on where and how it is used?
eg. for statistics gathering it doesn't matter so much. In this
case it would seem that you do want an actual online CPU... though
on looking at the workqueue code it seems that some of it would be
racy in a similar way, so perhaps this is handled elsewhere (I
can't see how, though).
>
>
>>Can't this deadlock if 2 CPUs each send work to the other
>>
>
>Then we would need to fix the workqueue flushing function.
>
>
Oh, you're right.
next prev parent reply other threads:[~2005-12-08 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:55 [PATCH] swap migration: Fix lru drain Christoph Lameter
2005-12-07 23:27 ` Nick Piggin
2005-12-08 0:43 ` Christoph Lameter
2005-12-08 0:58 ` Andrew Morton
2005-12-08 0:59 ` Nick Piggin [this message]
2005-12-08 0:13 ` Andrew Morton
2005-12-08 0:41 ` Christoph Lameter
2005-12-08 0:57 ` Andrew Morton
2005-12-08 1:14 ` Christoph Lameter
2005-12-08 5:02 ` [Lhms-devel] " KAMEZAWA Hiroyuki
2005-12-08 8:36 ` KAMEZAWA Hiroyuki
2005-12-08 8:43 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4397857D.8040604@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox