From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, lhms-devel@lists.sourceforge.net
Subject: Re: [Lhms-devel] Re: [PATCH] swap migration: Fix lru drain
Date: Thu, 08 Dec 2005 14:02:37 +0900 [thread overview]
Message-ID: <4397BE6D.9070303@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0512071706001.26471@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Wed, 7 Dec 2005, Andrew Morton wrote:
>
>
>>I'll change this to return 0 on success, or -ENOMEM. Bit more
>>conventional, no?
>
>
> Ok. That also allows the addition of other error conditions in the future.
> Need to revise isolate_lru_page to reflect that.
>
I think this 'schedule_on_each_cpu(lru_add_drain_per_cpu, NULL);' will be used
by memory-hot-removing code and some other codes.
How about move this to swap.c and name as 'lru_add_drain_all()' ?
(but there is no other users now....)
-- Kame
next prev parent reply other threads:[~2005-12-08 5:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:55 [PATCH] swap migration: Fix lru drain Christoph Lameter
2005-12-07 23:27 ` Nick Piggin
2005-12-08 0:43 ` Christoph Lameter
2005-12-08 0:58 ` Andrew Morton
2005-12-08 0:59 ` Nick Piggin
2005-12-08 0:13 ` Andrew Morton
2005-12-08 0:41 ` Christoph Lameter
2005-12-08 0:57 ` Andrew Morton
2005-12-08 1:14 ` Christoph Lameter
2005-12-08 5:02 ` KAMEZAWA Hiroyuki [this message]
2005-12-08 8:36 ` [Lhms-devel] " KAMEZAWA Hiroyuki
2005-12-08 8:43 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4397BE6D.9070303@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox