public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: jesper.juhl@gmail.com, linux-kernel@vger.kernel.org,
	coreteam@netfilter.org, jmorris@intercode.com.au,
	laforge@netfilter.org, akpm@osdl.org
Subject: Re: [PATCH] Decrease number of pointer derefs in nfnetlink_queue.c
Date: Thu, 08 Dec 2005 19:08:52 -0500	[thread overview]
Message-ID: <4398CB14.6020508@pobox.com> (raw)
In-Reply-To: <20051208.145148.36886043.davem@davemloft.net>

David S. Miller wrote:
> From: Jesper Juhl <jesper.juhl@gmail.com>
> Date: Thu, 8 Dec 2005 23:36:01 +0100
> 
> 
>>Here's a small patch to decrease the number of pointer derefs in
>>net/netfilter/nfnetlink_queue.c
>>
>>Benefits of the patch:
>> - Fewer pointer dereferences should make the code slightly faster.
>> - Size of generated code is smaller
>> - improved readability
> 
> 
> And you verified the compiler isn't making these transformations
> already?

Didn't the provided size(1) output would verify this?

In any case, I like the changes because it makes the code more readable, 
with the smaller code size as a pleasant side effect.  Due to increase 
readability, I would only be inclined to NAK if the code 
performance/size was adversely effected.

	Jeff



  parent reply	other threads:[~2005-12-09  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-08 22:36 [PATCH] Decrease number of pointer derefs in nfnetlink_queue.c Jesper Juhl
2005-12-08 22:51 ` David S. Miller
2005-12-08 23:10   ` Jesper Juhl
2005-12-08 23:56   ` Steven Rostedt
2005-12-09  0:08   ` Jeff Garzik [this message]
2005-12-09  5:04 ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4398CB14.6020508@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=jesper.juhl@gmail.com \
    --cc=jmorris@intercode.com.au \
    --cc=laforge@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox