From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4833E18C332 for ; Sun, 23 Nov 2025 15:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763912185; cv=none; b=WKqHBSn/f6JEYb3oCCGqoOFgQqARWxte12BeOPxPipu4oXIqwlncuqB3NdaCplKFE/fTkyzRB5l9nhbXC7LkBLoqkSU0c0D/JVqKw09MXmMIN+cJjFnO3/hJUKMqRahUh+kh9ddY3T3EiO1YTuffijB/bReAhlLD4xW6Qz+h9zE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763912185; c=relaxed/simple; bh=9nLYrVmMT/o7U+P86nEb1w144KAoMFwuV1z4oeFpKCE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=adLXkXK/rEKai9jEfFdxexH8bptqtXtD4jPnGdmlzaynlYojt05y6MldDfz7ejFAm1jGfZsmX+SK8KNRHC9mo3K8+NAGJ7FAczh4lLaYBCZUQyV8rByKeu8UFzoBH8wU4md3cfagV8tPzFMQYJqyiKqXb4yOn0KPYlMWDZxilg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AmQzmq4z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AmQzmq4z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD4F7C113D0; Sun, 23 Nov 2025 15:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763912184; bh=9nLYrVmMT/o7U+P86nEb1w144KAoMFwuV1z4oeFpKCE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AmQzmq4zejX1Oc/alh/3lJczN1ee4EacFi159+Yp96CIE7r8HrQkQXdfa0Spn7sKe rrSXRFDRWKz7IqLA3hkH2syTO+avl0c+gsfg3atGpavyVt/aCGr7pqa1cwSvv63jmk 8FERySFq6CCVuYYq58VYcbHehqcBg+cpj0u0vR0cf0nM0FOFmksMohRXBNmWUjtO2T CDRHt6DZ0eqB/ZCrHlmfIZpNLkNAZqx3FXcPSj1N1Zzv7f7LcqSleKVkssSqLHTHQb UGJhknt4nk4t9F+iAsdLJbC74CqDVvr1bTe7pJsuQgQZE6HnJdfsMn7nSMUGaxs4LA YbYpPqKLG4OHA== Message-ID: <439953a2-177f-4e7c-9bd2-0fc7d204ca1a@kernel.org> Date: Mon, 24 Nov 2025 00:36:20 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] extcon: int3496: replace use of system_wq with system_percpu_wq To: Marco Crivellari , linux-kernel@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko , MyungJoo Ham , Chanwoo Choi References: <20251104110105.116858-1-marco.crivellari@suse.com> From: Chanwoo Choi Content-Language: en-US In-Reply-To: <20251104110105.116858-1-marco.crivellari@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, 25. 11. 4. 20:01에 Marco Crivellari 이(가) 쓴 글: > Currently if a user enqueue a work item using schedule_delayed_work() the > used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use > WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to > schedule_work() that is using system_wq and queue_work(), that makes use > again of WORK_CPU_UNBOUND. > > This lack of consistentcy cannot be addressed without refactoring the API. > > This patch continues the effort to refactor worqueue APIs, which has begun > with the change introducing new workqueues and a new alloc_workqueue flag: > > commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") > commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") > > system_wq should be the per-cpu workqueue, yet in this name nothing makes > that clear, so replace system_wq with system_percpu_wq. > > The old wq (system_wq) will be kept for a few release cycles. > > Suggested-by: Tejun Heo > Signed-off-by: Marco Crivellari > --- > drivers/extcon/extcon-intel-int3496.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index ded1a85a5549..7d16d5b7d58f 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -106,7 +106,7 @@ static irqreturn_t int3496_thread_isr(int irq, void *priv) > struct int3496_data *data = priv; > > /* Let the pin settle before processing it */ > - mod_delayed_work(system_wq, &data->work, DEBOUNCE_TIME); > + mod_delayed_work(system_percpu_wq, &data->work, DEBOUNCE_TIME); > > return IRQ_HANDLED; > } > @@ -181,7 +181,7 @@ static int int3496_probe(struct platform_device *pdev) > } > > /* process id-pin so that we start with the right status */ > - queue_delayed_work(system_wq, &data->work, 0); > + queue_delayed_work(system_percpu_wq, &data->work, 0); > flush_delayed_work(&data->work); > > platform_set_drvdata(pdev, data); Applied it. Thanks. -- Best Regards, Samsung Electronics Chanwoo Choi