[PATCH] extcon: int3496: replace use of system_wq with system_percpu_wq

[PATCH] extcon: int3496: replace use of system_wq with system_percpu_wq

[Marco Crivellari]

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

The old wq (system_wq) will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
 drivers/extcon/extcon-intel-int3496.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
index ded1a85a5549..7d16d5b7d58f 100644
--- a/drivers/extcon/extcon-intel-int3496.c
+++ b/drivers/extcon/extcon-intel-int3496.c
@@ -106,7 +106,7 @@ static irqreturn_t int3496_thread_isr(int irq, void *priv)
 	struct int3496_data *data = priv;
 
 	/* Let the pin settle before processing it */
-	mod_delayed_work(system_wq, &data->work, DEBOUNCE_TIME);
+	mod_delayed_work(system_percpu_wq, &data->work, DEBOUNCE_TIME);
 
 	return IRQ_HANDLED;
 }
@@ -181,7 +181,7 @@ static int int3496_probe(struct platform_device *pdev)
 	}
 
 	/* process id-pin so that we start with the right status */
-	queue_delayed_work(system_wq, &data->work, 0);
+	queue_delayed_work(system_percpu_wq, &data->work, 0);
 	flush_delayed_work(&data->work);
 
 	platform_set_drvdata(pdev, data);
-- 
2.51.1

Re: [PATCH] extcon: int3496: replace use of system_wq with system_percpu_wq

[Chanwoo Choi]

Hi,

25. 11. 4. 20:01에 Marco Crivellari 이(가) 쓴 글:
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
> 
> This lack of consistentcy cannot be addressed without refactoring the API.
> 
> This patch continues the effort to refactor worqueue APIs, which has begun
> with the change introducing new workqueues and a new alloc_workqueue flag:
> 
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> 
> system_wq should be the per-cpu workqueue, yet in this name nothing makes
> that clear, so replace system_wq with system_percpu_wq.
> 
> The old wq (system_wq) will be kept for a few release cycles.
> 
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> ---
>  drivers/extcon/extcon-intel-int3496.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index ded1a85a5549..7d16d5b7d58f 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -106,7 +106,7 @@ static irqreturn_t int3496_thread_isr(int irq, void *priv)
>  	struct int3496_data *data = priv;
>  
>  	/* Let the pin settle before processing it */
> -	mod_delayed_work(system_wq, &data->work, DEBOUNCE_TIME);
> +	mod_delayed_work(system_percpu_wq, &data->work, DEBOUNCE_TIME);
>  
>  	return IRQ_HANDLED;
>  }
> @@ -181,7 +181,7 @@ static int int3496_probe(struct platform_device *pdev)
>  	}
>  
>  	/* process id-pin so that we start with the right status */
> -	queue_delayed_work(system_wq, &data->work, 0);
> +	queue_delayed_work(system_percpu_wq, &data->work, 0);
>  	flush_delayed_work(&data->work);
>  
>  	platform_set_drvdata(pdev, data);

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

Re: [PATCH] extcon: int3496: replace use of system_wq with system_percpu_wq

[Marco Crivellari]

Hi,

On Sun, Nov 23, 2025 at 4:36 PM Chanwoo Choi <chanwoo@kernel.org> wrote:
> >  drivers/extcon/extcon-intel-int3496.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >[...]
>
> Applied it. Thanks.

I was checking the code and noticed this still seems not merged into
master (linux).
Is there something wrong / am I missing something?

Thank you!

-- 

Marco Crivellari

SUSE Labs