From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: dada1@cosmosbay.com, pj@sgi.com, linux-kernel@vger.kernel.org,
Simon.Derr@bull.net, ak@suse.de, clameter@sgi.com
Subject: Re: [PATCH] Cpuset: rcu optimization of page alloc hook
Date: Mon, 12 Dec 2005 20:38:59 +1100 [thread overview]
Message-ID: <439D4533.6000708@yahoo.com.au> (raw)
In-Reply-To: <20051212011108.0725524d.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>
>>Is it a good idea for all kmem_cache_t? If so, can we move
>>__read_mostly to the type definition?
>>
>
>
> Yes, I suppose that's worthwhile.
>
> We've been shuffling towards removing kmem_cache_t in favour of `struct
> kmem_cache', but this is an argument against doing that.
>
> If we can work out how:
>
> void foo()
> {
> kmem_cache_t *p;
> }
>
> That'll barf.
>
Mmm. And the structure within structure, which Eric points out. I assumed
without grepping that those were mostly confined to slab itself and would
be easy to special case, but it turns out networking makes some use of
them too.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-12-12 9:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-11 23:31 [PATCH] Cpuset: rcu optimization of page alloc hook Paul Jackson
2005-12-12 3:29 ` Andi Kleen
2005-12-12 6:11 ` Paul Jackson
2005-12-12 6:21 ` Andi Kleen
2005-12-12 6:50 ` Paul Jackson
2005-12-12 8:49 ` Eric Dumazet
2005-12-12 8:54 ` Nick Piggin
2005-12-12 9:06 ` Eric Dumazet
2005-12-12 9:11 ` Andrew Morton
2005-12-12 9:38 ` Nick Piggin [this message]
2005-12-12 10:02 ` Paul Jackson
2005-12-12 10:12 ` Andrew Morton
2005-12-13 15:53 ` Paul Jackson
2005-12-13 16:31 ` Eric Dumazet
2005-12-13 17:42 ` Christoph Lameter
2005-12-13 17:56 ` Eric Dumazet
2005-12-13 18:07 ` Christoph Lameter
2005-12-13 21:03 ` Paul Jackson
2005-12-13 21:16 ` Christoph Lameter
2005-12-13 21:38 ` Eric Dumazet
2005-12-13 22:23 ` Paul Jackson
2005-12-13 22:29 ` Christoph Lameter
2005-12-14 3:54 ` Paul Jackson
2005-12-14 4:02 ` Andi Kleen
2005-12-14 4:06 ` Paul Jackson
2005-12-14 8:06 ` Eric Dumazet
2005-12-14 8:40 ` Paul Jackson
2005-12-13 20:08 ` Paul Jackson
2005-12-13 20:29 ` Eric Dumazet
2005-12-13 22:35 ` Paul Jackson
2005-12-13 21:44 ` Paul Jackson
2005-12-13 17:37 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439D4533.6000708@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Simon.Derr@bull.net \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox