From: Nick Piggin <nickpiggin@yahoo.com.au>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
David Gibson <david@gibson.dropbear.id.au>,
Jens Axboe <axboe@suse.de>,
"Michael S. Tsirkin" <mst@mellanox.co.il>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PageCompound avoid page[1].mapping
Date: Mon, 12 Dec 2005 21:46:56 +1100 [thread overview]
Message-ID: <439D5520.6000400@yahoo.com.au> (raw)
In-Reply-To: <20051210070248.GE2838@holomorphy.com>
William Lee Irwin III wrote:
> On Fri, Dec 09, 2005 at 09:56:42PM +0000, Hugh Dickins wrote:
>
>>- page[1].mapping = (void *)free_huge_page;
>>+ page[1].index = (unsigned long)free_huge_page; /* set dtor */
>> for (i = 0; i < (HPAGE_SIZE/PAGE_SIZE); ++i)
>> clear_highpage(&page[i]);
>> return page;
>
>
> Hmm, ->lru would be nicer. What prompted the use of ->index?
>
Yes, agreed. That would rid you of __page_count() too.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-12-12 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 21:56 [PATCH] PageCompound avoid page[1].mapping Hugh Dickins
2005-12-09 22:36 ` Andrew Morton
2005-12-10 7:02 ` William Lee Irwin III
2005-12-12 10:46 ` Nick Piggin [this message]
2005-12-12 0:26 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439D5520.6000400@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox