Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation

Ingo Molnar
2005-12-13T09:14:16Z

* Christoph Hellwig <hch@infradead.org> wrote:

> >
> > Remove -Wdeclaration-after-statement
> >
> > Now that gcc 2.95 is not supported anymore it's ok to use C99
> > style mixed declarations everywhere.
>
> Nack. This code style is pure obsfucation and we should disallow it
> forever.

agreed. I often get quilt mismerges uncovered by that warning. If
someone wants to start a new section of code that is too large, it
should go into a separate function.

Ingo