From: JANAK DESAI <janak@us.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: chrisw@osdl.org, dwmw2@infradead.org, jamie@shareable.org,
serue@us.ibm.com, mingo@elte.hu, linuxram@us.ibm.com,
jmorris@namei.org, sds@tycho.nsa.gov, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 7/9] unshare system call : allow unsharing of namespace
Date: Tue, 13 Dec 2005 09:11:24 -0500 [thread overview]
Message-ID: <439ED68C.5010605@us.ibm.com> (raw)
In-Reply-To: <20051213135205.GP27946@ftp.linux.org.uk>
Al Viro wrote:
>On Mon, Dec 12, 2005 at 10:00:09PM -0500, JANAK DESAI wrote:
>
>
>>[PATCH -mm 7/9] unshare system call: allow unsharing of namespace
>>
>>
>
>You need a pointer to new fs_struct, since that's what will be modified.
>As it is, you are modifying ->root, etc. of old fs_struct, which is OK
>only when it's not shared.
>
> What you need is to pass new_fs ? new_fs : current->fs as a separate
>argument to your dup_namespace().
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
>
Thanks. I will make all the changes as per your feedback, re-test and
resubmit the
series later today.
-Janak
next prev parent reply other threads:[~2005-12-13 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 3:00 [PATCH -mm 7/9] unshare system call : allow unsharing of namespace JANAK DESAI
2005-12-13 13:52 ` Al Viro
2005-12-13 14:11 ` JANAK DESAI [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-13 13:43 JANAK DESAI
2005-12-13 22:54 [PATCH -mm 7/9] unshare system call: " JANAK DESAI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439ED68C.5010605@us.ibm.com \
--to=janak@us.ibm.com \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=dwmw2@infradead.org \
--cc=jamie@shareable.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mingo@elte.hu \
--cc=sds@tycho.nsa.gov \
--cc=serue@us.ibm.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox