Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error

[Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>]

Thank you Alan,

Alan Cox wrote:
> This is done deliberately on some systems and is why we have the patches
> I submitted to Andrew Morton which are in his tree and allow you to set
> "panic_on_unrecovered_nmi" to halt on a memory error.
> 
> See the -mm tree. The functionality is there. Also see the various
> x86-64 logging tools which can parse out MCE based reports.

I could find your code in the -mm tree. It looks good :-)
But just one point, isn't it better to use die_nmi() instead of panic()?

 >>        if (panic_on_unrecovered_nmi)
 >>                panic("NMI: Not continuing");

H.Seto