public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: David Laight <David.Laight@ACULAB.COM>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Subject: RE: Linux 6.1-rc3 build fail in include/linux/bpf.h
Date: Mon, 31 Oct 2022 12:03:15 +0000	[thread overview]
Message-ID: <439af02a169149f28ba0a4e3bbc729ee@AcuMS.aculab.com> (raw)
In-Reply-To: <439d8dc735bb4858875377df67f1b29a@AcuMS.aculab.com>

From: David Laight
> Sent: 31 October 2022 11:15
> 
> The 6.1-rc3 sources fail to build because bpf.h unconditionally
> #define BPF_DISPATCHER_ATTRIBUTES __attribute__((patchable_function_entry(5)))
> for X86_64 builds.
> 
> I'm pretty sure that should depend on some other options
> since the compiler isn't required to support it.
> (The gcc 7.5.0 on my Ubunti 18.04 system certainly doesn't)
> 
> The only other reference to that attribute is in the definition
> of 'notrace' in compiler.h.

I think patchable_function_entry was added in gcc 8.
Documentation/process/changes.rst gives the minimal gcc version for
building the kernel as 5.1.

I doubt a increasing it to 8 is acceptable.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

  reply	other threads:[~2022-10-31 12:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 11:14 Linux 6.1-rc3 build fail in include/linux/bpf.h David Laight
2022-10-31 12:03 ` David Laight [this message]
2022-10-31 12:17 ` Jiri Olsa
2022-10-31 15:21   ` Peter Zijlstra
2022-10-31 21:53     ` Jiri Olsa
2022-11-01 11:00       ` Björn Töpel
2022-11-01 13:39         ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439af02a169149f28ba0a4e3bbc729ee@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox