From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add mem_nmi_panic enable system to panic on hard error
Date: Thu, 15 Dec 2005 10:53:49 +0900 [thread overview]
Message-ID: <43A0CCAD.2030903@jp.fujitsu.com> (raw)
In-Reply-To: <1134558344.25663.8.camel@localhost.localdomain>
Alan Cox wrote:
>>I could find your code in the -mm tree. It looks good :-)
>>But just one point, isn't it better to use die_nmi() instead of panic()?
>>
>> >> if (panic_on_unrecovered_nmi)
>> >> panic("NMI: Not continuing");
>
>
> At the point we halt for an unrecovered NMI the call trace isnt likely
> to be interesting and the message being visible is most important. I'm
> not sure if die_nmi would be better therefore - dunno what other folks
> think ?
Indeed, that's true.
In this case of an unrecovered NMI, the call trace is useless.
Thank you for pointing it out.
H.Seto
prev parent reply other threads:[~2005-12-15 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 6:38 [PATCH] Add mem_nmi_panic enable system to panic on hard error Hidetoshi Seto
2005-12-13 6:48 ` Dave Jones
2005-12-13 8:56 ` Hidetoshi Seto
2005-12-13 12:23 ` Alan Cox
2005-12-14 8:49 ` Hidetoshi Seto
2005-12-14 11:05 ` Alan Cox
2005-12-15 1:53 ` Hidetoshi Seto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A0CCAD.2030903@jp.fujitsu.com \
--to=seto.hidetoshi@jp.fujitsu.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox