public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Miles Lane <miles.lane@gmail.com>,
	linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1
Date: Thu, 15 Dec 2005 20:06:30 +1100	[thread overview]
Message-ID: <43A13216.8000104@yahoo.com.au> (raw)
In-Reply-To: <20051215004028.0bf9791f.akpm@osdl.org>

Andrew Morton wrote:

>>A little later, I get this:
>>
>>[4294676.542000] BUG: using smp_processor_id() in preemptible
>>[00000001] code: rcS/942
>>[4294676.542000] caller is mod_page_state_offset+0x12/0x28
>>[4294676.542000]  [<c1003723>] dump_stack+0x16/0x1a
>>[4294676.554000]  [<c110c1eb>] debug_smp_processor_id+0x77/0x90
>>[4294676.565000]  [<c10413d3>] mod_page_state_offset+0x12/0x28
>>[4294676.577000]  [<c104911b>] __handle_mm_fault+0x1f/0x18e
>>[4294676.589000]  [<c1013d7f>] do_page_fault+0x170/0x492
>>[4294676.600000]  [<c10033f7>] error_code+0x4f/0x54
>>[4294676.612000]  [<c10027ae>] ret_from_fork+0x6/0x14
> 
> 
> Nick.
> 
> 

Silly me, it is doing the local_irq_save *after* the __get_cpu_var.
Sorry for the typo. However the bug is harmless and will just result
in skewed statistics in the very rare chance of a race.

Thanks for reporting.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com 

  parent reply	other threads:[~2005-12-15  9:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-15  8:35 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1 Miles Lane
2005-12-15  8:40 ` Andrew Morton
2005-12-15  9:00   ` Andrew Morton
2005-12-15 18:48     ` Dave Jones
2005-12-15  9:06   ` Nick Piggin [this message]
2005-12-15 18:20   ` 2.6.15-rc5-mm3 -- bus may be hidden warning Dominik Brodowski
2005-12-15  8:40 ` 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1 Miles Lane
2005-12-15 12:24 ` Alan Cox
2005-12-15 16:33   ` Michal Piotrowski
2005-12-17 20:33 ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A13216.8000104@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox