From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jordan Crouse <jordan.crouse@amd.com>,
linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
info-linux@ldcmail.amd.com
Subject: Re: Geode LX HW RNG Support
Date: Thu, 15 Dec 2005 17:07:22 -0500 [thread overview]
Message-ID: <43A1E91A.4060400@pobox.com> (raw)
In-Reply-To: <20051215140622.53c37335.akpm@osdl.org>
Andrew Morton wrote:
> "Jordan Crouse" <jordan.crouse@amd.com> wrote:
>
>>>Should all the Geode additions to hw_random.c be inside __i386__, like VIA?
>>
>>I thought that a early version did that and somebody took exception to
>>it, but I can't find any e-mails to that effect right now. Obviously,
>>the defines are only useful when you have a Geode CPU (and thus a x86_32),
>>so if nobody complains, I think that would be fine.
>
>
> Fair enough. Please send an update sometime.
>
> We might as well do s/__i386__/X86_32/ throughout that file - bit pointless
> but it's a little bit more idiomatic.
What about the rng rewrite recently posted? Any opinions on that?
I lean towards applying it, long term, but IIRC there were problems that
prevented immediate merge.
Jeff
next prev parent reply other threads:[~2005-12-15 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 21:12 [PATCH 1/3] Base support for AMD Geode GX/LX processors Jordan Crouse
2005-12-15 21:14 ` [PATCH 2/3] Geode LX HW RNG Support Jordan Crouse
2005-12-15 21:16 ` [PATCH 3/3] APM Screen Blanking fix Jordan Crouse
2005-12-15 21:45 ` Andrew Morton
[not found] ` <LYRIS-4270-4193-2005.12.15-14.45.16--jordan.crouse#amd.com@whitestar.amd.com>
2005-12-15 21:56 ` Jordan Crouse
2005-12-15 21:39 ` [PATCH 2/3] Geode LX HW RNG Support Andrew Morton
2005-12-15 21:44 ` Jordan Crouse
2005-12-15 22:06 ` Andrew Morton
2005-12-15 22:07 ` Jeff Garzik [this message]
2005-12-15 22:47 ` Andrew Morton
2005-12-15 22:48 ` Deepak Saxena
2005-12-15 21:36 ` [PATCH 1/3] Base support for AMD Geode GX/LX processors Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A1E91A.4060400@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=info-linux@ldcmail.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox