* bug in get_name of export operations?
@ 2005-12-19 14:56 Vladimir V. Saveliev
2005-12-20 10:52 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir V. Saveliev @ 2005-12-19 14:56 UTC (permalink / raw)
To: LKML
Hello
Please point my error if I am wrong:
fs/exportfs/expfs.c:get_name() opens a directory with:
file = dentry_open(dget(dentry), NULL, O_RDONLY);
which results in file where file->f_vfsmnt == NULL.
Then fs/readdir.c:vfs_readdir() and, therefore,
include/linux/fs.h:file_accessed(file) are called.
file_accessed() calls fs/inode.c:touch_atime() which tryies to dereference mnt
which is NULL.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug in get_name of export operations?
2005-12-19 14:56 bug in get_name of export operations? Vladimir V. Saveliev
@ 2005-12-20 10:52 ` Andrew Morton
2005-12-20 11:35 ` Vladimir V. Saveliev
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-12-20 10:52 UTC (permalink / raw)
To: Vladimir V. Saveliev; +Cc: linux-kernel, Christoph Hellwig
"Vladimir V. Saveliev" <vs@namesys.com> wrote:
>
> Hello
>
> Please point my error if I am wrong:
>
> fs/exportfs/expfs.c:get_name() opens a directory with:
> file = dentry_open(dget(dentry), NULL, O_RDONLY);
> which results in file where file->f_vfsmnt == NULL.
>
> Then fs/readdir.c:vfs_readdir() and, therefore,
> include/linux/fs.h:file_accessed(file) are called.
> file_accessed() calls fs/inode.c:touch_atime() which tryies to dereference mnt
> which is NULL.
>
I think you're looking at the -mm tree, in which Christoph changed all that
stuff.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug in get_name of export operations?
2005-12-20 10:52 ` Andrew Morton
@ 2005-12-20 11:35 ` Vladimir V. Saveliev
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir V. Saveliev @ 2005-12-20 11:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Christoph Hellwig
Hello
Andrew Morton wrote:
> "Vladimir V. Saveliev" <vs@namesys.com> wrote:
>>Hello
>>
>>Please point my error if I am wrong:
>>
>>fs/exportfs/expfs.c:get_name() opens a directory with:
>>file = dentry_open(dget(dentry), NULL, O_RDONLY);
>>which results in file where file->f_vfsmnt == NULL.
>>
>>Then fs/readdir.c:vfs_readdir() and, therefore,
>>include/linux/fs.h:file_accessed(file) are called.
>>file_accessed() calls fs/inode.c:touch_atime() which tryies to dereference mnt
>>which is NULL.
>>
>
> I think you're looking at the -mm tree, in which Christoph changed all that
> stuff.
>
Ah, sorry, yes, I found that in 2.6.15-rc5-mm3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-20 11:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-19 14:56 bug in get_name of export operations? Vladimir V. Saveliev
2005-12-20 10:52 ` Andrew Morton
2005-12-20 11:35 ` Vladimir V. Saveliev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox