public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: borsa77@libero.it
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: kaos@ocs.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Correction to kmod.c control loop
Date: Wed, 21 Dec 2005 01:27:23 +0100	[thread overview]
Message-ID: <43A8AF7B.3540.115294E@localhost> (raw)
In-Reply-To: <9a8748490512201523o9430a9ew21135887202f2dbd@mail.gmail.com>

On 21 Dec 2005 at 0:23, Jesper Juhl wrote:

> On 12/21/05, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> > > > > -       if (i > MAX_KMOD_CONCURRENT)
> > > > > +       if (i < MAX_KMOD_CONCURRENT)
> > > >
> > > > You changed MAX_KMOD_CONCURRENT from a constant to a variable above,
> > > > but you never assign a value to it, so here you are comparing i to an
> > > > uninitialized variable, not good.
> > >
> > >
> > > It is a _static_ local variable so it is assigned automatically to zero, I
> > > think.
> > >
> Hmm, yes, I wonder at that a bit as well, why static?

To maintain the value through a call of modprobe and a following one, 
so if the first fails you can maybe have the loading with the others.

  parent reply	other threads:[~2005-12-21  0:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <43A89499.1824.AC225C@localhost>
     [not found] ` <9a8748490512201511v62153b33pfae22e512103552a@mail.gmail.com>
2005-12-21  0:15   ` [PATCH] Correction to kmod.c control loop borsa77
     [not found]   ` <9a8748490512201523o9430a9ew21135887202f2dbd@mail.gmail.com>
2005-12-21  0:27     ` borsa77 [this message]
2005-12-20 20:43 borsa77
2005-12-20 21:08 ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A8AF7B.3540.115294E@localhost \
    --to=borsa77@libero.it \
    --cc=jesper.juhl@gmail.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox