public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Wool <vwool@ru.mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH/RFC] SPI core: turn transfers to be linked list
Date: Wed, 21 Dec 2005 16:22:27 +0300	[thread overview]
Message-ID: <43A95713.6020405@ru.mvista.com> (raw)
In-Reply-To: <200512200011.57052.david-b@pacbell.net>

David Brownell wrote:

>>The list setting commands are pretty essential and will not add a lot to 
>>the assembly code.
>>    
>>
>
>I'm not totally averse to such changes, but you don't seem to be making
>the best arguments.  Example:  they're clearly not "essential" because
>transfer queues work today with the lists at the spi_message level.
>  
>
One more reason for that that came out only recently: suppore we're 
adding transfers to an already configured message (i. e. with some 
transfers set up already). This 'chaning' may happen for some kinds of 
devices. And in case transfers is an array, we should either be apriory 
aware of whether the chaining will take place or allocate an array large 
enough to hold additional transfers. Neither of these look good to me, 
and having a linked list of transfers will definitely solve this problem.

Vitaly


  parent reply	other threads:[~2005-12-21 13:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-17 21:18 [PATCH/RFC] SPI core: turn transfers to be linked list Vitaly Wool
2005-12-18 20:40 ` David Brownell
2005-12-19  7:49   ` Vitaly Wool
2005-12-19 17:00     ` Greg KH
2005-12-19 20:03       ` Vitaly Wool
2005-12-20  8:11     ` David Brownell
2005-12-20 18:15       ` Vitaly Wool
2005-12-21 13:22       ` Vitaly Wool [this message]
2005-12-22 17:55         ` David Brownell
2005-12-22 22:12           ` Vitaly Wool
2005-12-22 23:57             ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A95713.6020405@ru.mvista.com \
    --to=vwool@ru.mvista.com \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox