From: Vitaly Wool <vwool@ru.mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, spi-devel-general@sourceforge.net
Subject: Re: [PATCH 2.6-git] SPI: add set_clock() to bitbang
Date: Fri, 23 Dec 2005 00:23:36 +0300 [thread overview]
Message-ID: <43AB1958.1070407@ru.mvista.com> (raw)
In-Reply-To: <200512220840.34152.david-b@pacbell.net>
David Brownell wrote:
>On Thursday 22 December 2005 7:04 am, Vitaly Wool wrote:
>
>
>>Hi David,
>>
>>inlined is the small patch that adds set_clock function to the spi_bitbang structure.
>>
>>
>
>This is actually not needed. Clocks are set through the setup() method
>in the spi_master, and controller drivers are (courtesy of the library
>approach) free to provide their own. Drivers for word-at-a-time hardware
>would still need to call spi_bitbang_setup() in their own setup() code,
>to set up the per-device controller_state, and spi_bitbang_cleanup() in
>their own cleanup() code, to deallocate it.
>
>
Where is it supposed to call setup? I guess it's anyway gonna be
per-transfer, right?
Or am I missing something?
Vitaly
next prev parent reply other threads:[~2005-12-22 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 15:04 [PATCH 2.6-git] SPI: add set_clock() to bitbang Vitaly Wool
2005-12-22 16:40 ` David Brownell
2005-12-22 21:23 ` Vitaly Wool [this message]
2005-12-22 21:37 ` David Brownell
2005-12-22 21:42 ` Vitaly Wool
2005-12-23 0:37 ` David Brownell
2005-12-23 7:08 ` Vitaly Wool
2005-12-23 8:28 ` David Brownell
2005-12-23 8:38 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43AB1958.1070407@ru.mvista.com \
--to=vwool@ru.mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox