public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Wool <vwool@ru.mvista.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, spi-devel-general@sourceforge.net
Subject: Re: [PATCH 2.6-git] SPI: add set_clock() to bitbang
Date: Fri, 23 Dec 2005 00:42:15 +0300	[thread overview]
Message-ID: <43AB1DB7.3080505@ru.mvista.com> (raw)
In-Reply-To: <200512221337.39305.david-b@pacbell.net>

David Brownell wrote:

>>>This is actually not needed.  Clocks are set through the setup() method
>>>      
>>>
>>...
>>
>>Where is it supposed to call setup? I guess it's anyway gonna be 
>>per-transfer, right?
>>Or am I missing something?
>>    
>>
>
>When the device is created, the core calls setup() to get things like
>chipselect polarity sorted out and put into the inactive state.   That
>matches the board-specific defaults associated with that device, which
>would be a function of voltage, routing, and more.
>
>And from then on, it'd be rare to ever call setup() again ... though
>drivers certainly could do that between spi_message interactions with
>a given device.
>  
>
No, suppose there're two devices behind the same SPI bus that have 
different clock constraints. As active SPI device change may well happen 
when each new message is processed, we'll need to set up clocks again 
for each message. Right?

Vitaly

  reply	other threads:[~2005-12-22 21:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-22 15:04 [PATCH 2.6-git] SPI: add set_clock() to bitbang Vitaly Wool
2005-12-22 16:40 ` David Brownell
2005-12-22 21:23   ` Vitaly Wool
2005-12-22 21:37     ` David Brownell
2005-12-22 21:42       ` Vitaly Wool [this message]
2005-12-23  0:37         ` David Brownell
2005-12-23  7:08           ` Vitaly Wool
2005-12-23  8:28             ` David Brownell
2005-12-23  8:38               ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43AB1DB7.3080505@ru.mvista.com \
    --to=vwool@ru.mvista.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox