* [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
@ 2006-01-02 15:45 Graham Gower
2006-01-02 16:37 ` Daniel Drake
0 siblings, 1 reply; 6+ messages in thread
From: Graham Gower @ 2006-01-02 15:45 UTC (permalink / raw)
To: linux-kernel, prism54-devel
dev_kfree_skb shouldn't be used in an IRQ context.
Signed-off-by: Graham Gower <graham.gower@gmail.com>
--- linux/drivers/net/wireless/prism54/islpci_eth.c.orig 2006-01-03
01:23:27.000000000 +1030
+++ linux/drivers/net/wireless/prism54/islpci_eth.c 2006-01-03
00:38:46.000000000 +1030
@@ -178,7 +178,7 @@
#endif
newskb->dev = skb->dev;
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
skb = newskb;
}
}
@@ -242,7 +242,7 @@
drop_free:
/* free the skbuf structure before aborting */
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
skb = NULL;
priv->statistics.tx_dropped++;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
2006-01-02 15:45 Graham Gower
@ 2006-01-02 16:37 ` Daniel Drake
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Drake @ 2006-01-02 16:37 UTC (permalink / raw)
To: Graham Gower; +Cc: linux-kernel, prism54-devel
Graham Gower wrote:
> dev_kfree_skb shouldn't be used in an IRQ context.
>
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>
>
> --- linux/drivers/net/wireless/prism54/islpci_eth.c.orig 2006-01-03
> 01:23:27.000000000 +1030
> +++ linux/drivers/net/wireless/prism54/islpci_eth.c 2006-01-03
> 00:38:46.000000000 +1030
Patch header is linewrapped (patch seems OK though).
You probably want to send this to Jeff Garzik CC'ing the netdev list. I
didn't get any response from the prism54 developers when I submitted a
fix for a similar problem in November.
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
@ 2006-01-03 9:58 Roger While
2006-01-03 12:19 ` Graham Gower
0 siblings, 1 reply; 6+ messages in thread
From: Roger While @ 2006-01-03 9:58 UTC (permalink / raw)
To: graham.gower; +Cc: linux-kernel
What makes you think this is in IRQ context ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
2006-01-03 9:58 [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context Roger While
@ 2006-01-03 12:19 ` Graham Gower
2006-01-03 13:11 ` Patrick McHardy
0 siblings, 1 reply; 6+ messages in thread
From: Graham Gower @ 2006-01-03 12:19 UTC (permalink / raw)
To: Roger While; +Cc: linux-kernel, netdev
012345678901234567890123456789012345678901234567890123456789
On 03/01/06, Roger While <simrw@sim-basis.de> wrote:
> What makes you think this is in IRQ context ?
>
Er... yeah. I must have been off my nut when I wrote that comment.
A more apt comment should perhaps have been "dev_kfree_skb shouldn't be
used with interrupts disabled". Forgive my noobness, I'm a kernel patch virgin.
My logs were starting to fill with messages exatcly like that mentioned here:
http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840
In any event, the patch at the end of that link was never applied (it doesn't
fix the other call to dev_kfree_skb). After applying my patch, I've not had any
more messages in the logs.
Graham
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
2006-01-03 12:19 ` Graham Gower
@ 2006-01-03 13:11 ` Patrick McHardy
2006-01-03 23:03 ` Graham Gower
0 siblings, 1 reply; 6+ messages in thread
From: Patrick McHardy @ 2006-01-03 13:11 UTC (permalink / raw)
To: Graham Gower; +Cc: Roger While, linux-kernel, netdev
Graham Gower wrote:
> My logs were starting to fill with messages exatcly like that mentioned here:
> http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840
>
> In any event, the patch at the end of that link was never applied (it doesn't
> fix the other call to dev_kfree_skb). After applying my patch, I've not had any
> more messages in the logs.
The patch has been applied to 2.6.15-rc. Only the first hunk of your
patch is still required, but it doesn't apply anymore. Can you send
a new patch against 2.6.15 please?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context
2006-01-03 13:11 ` Patrick McHardy
@ 2006-01-03 23:03 ` Graham Gower
0 siblings, 0 replies; 6+ messages in thread
From: Graham Gower @ 2006-01-03 23:03 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Roger While, linux-kernel, netdev
On 03/01/06, Patrick McHardy <kaber@trash.net> wrote:
> Graham Gower wrote:
> > My logs were starting to fill with messages exatcly like that mentioned here:
> > http://patchwork.netfilter.org/netfilter-devel/patch.pl?id=2840
> >
> > In any event, the patch at the end of that link was never applied (it doesn't
> > fix the other call to dev_kfree_skb). After applying my patch, I've not had any
> > more messages in the logs.
>
> The patch has been applied to 2.6.15-rc. Only the first hunk of your
> patch is still required, but it doesn't apply anymore. Can you send
> a new patch against 2.6.15 please?
>
Ok, here's a new one. Hope I got it right this time.
Signed-off-by: Graham Gower <graham.gower@gmail.com>
--- linux-2.6.15/drivers/net/wireless/prism54/islpci_eth.c.orig
+++ linux-2.6.15/drivers/net/wireless/prism54/islpci_eth.c
@@ -177,7 +177,7 @@
#endif
newskb->dev = skb->dev;
- dev_kfree_skb(skb);
+ dev_kfree_skb_irq(skb);
skb = newskb;
}
}
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-01-03 23:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-03 9:58 [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context Roger While
2006-01-03 12:19 ` Graham Gower
2006-01-03 13:11 ` Patrick McHardy
2006-01-03 23:03 ` Graham Gower
-- strict thread matches above, loose matches on Subject: below --
2006-01-02 15:45 Graham Gower
2006-01-02 16:37 ` Daniel Drake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox