From: "H. Peter Anvin" <hpa@zytor.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andi Kleen <ak@suse.de>,
"Viro, Al" <viro@ftp.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Limit sendfile() to 2^31-PAGE_CACHE_SIZE bytes without error
Date: Wed, 04 Jan 2006 10:41:51 -0800 [thread overview]
Message-ID: <43BC16EF.50107@zytor.com> (raw)
In-Reply-To: <43BC030A.1060208@redhat.com>
Ulrich Drepper wrote:
> Linus Torvalds wrote:
>
>>Ok, this patch looks ok, if it's confirmed to unbreak apache.
>
> Yes, sounds reasonable. But I don't think that, as Peter suggested in
> another mail, that glibc should automatically wrap the syscall to
> provide support for larger sizes. The caller probably should know when
> a transfer was cut short.
>
Agreed; that's exactly what a short return in supposed to do. Since a
short return is compatible with the defined API, that's not a problem.
However, this patch only addresses sendfile(), and this is apparently a
much more pervasive problem. We need something similar for all the I/O
system calls that are affected by this particular issue.
-hpa
next prev parent reply other threads:[~2006-01-04 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <43BB348F.3070108@zytor.com>
[not found] ` <200601040451.20411.ak@suse.de>
[not found] ` <Pine.LNX.4.64.0601032051300.3668@g5.osdl.org>
[not found] ` <43BB5646.2040504@zytor.com>
2006-01-04 5:33 ` [PATCH] Limit sendfile() to 2^31-PAGE_CACHE_SIZE bytes without error H. Peter Anvin
2006-01-04 17:02 ` Linus Torvalds
2006-01-04 17:16 ` Ulrich Drepper
2006-01-04 18:41 ` H. Peter Anvin [this message]
2006-01-04 18:40 ` Linus Torvalds
2006-01-04 18:58 ` H. Peter Anvin
2006-01-04 19:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BC16EF.50107@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox