From: Pierre Ossman <drzeus-list@drzeus.cx>
To: jordan.crouse@amd.com
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MMC] Minimise protocol awareness in Au1x00 driver
Date: Sat, 07 Jan 2006 00:43:32 +0100 [thread overview]
Message-ID: <43BF00A4.8070606@drzeus.cx> (raw)
In-Reply-To: <20060106234012.31480.88314.stgit@poseidon.drzeus.cx>
Pierre Ossman wrote:
> The Au1x00 MMC/SD driver currently contains switch statements based on
> protocol opcodes, not on desired behaviour.
>
> Unfortunately the AMD specification is not detailed enough to determine
> how the controller will behave for the response settings. For now, it will
> have to suffice to warn when we have an unknown response type.
>
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> ---
>
>
Whilst doing this I also noticed how horribly broken this driver is with
regard to sending the stop command. Instead of sending the requested
command it sends a hard coded opcode!! Jordan, please fix this ASAP.
Rgds
Pierre
next prev parent reply other threads:[~2006-01-06 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 23:40 [PATCH] [MMC] Minimise protocol awareness in Au1x00 driver Pierre Ossman
2006-01-06 23:43 ` Pierre Ossman [this message]
2006-01-07 1:01 ` Jordan Crouse
2006-01-07 1:09 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BF00A4.8070606@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox