From: Ian Molton <spyro@f2s.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix arm26 THREAD_SIZE
Date: Sat, 07 Jan 2006 00:37:21 +0000 [thread overview]
Message-ID: <43BF0D41.6060003@f2s.com> (raw)
In-Reply-To: <20060106161608.GG12131@stusta.de>
Adrian Bunk wrote:
Looks good to me. cant recall why that got that way, but the div by zero
definately went away at the time. certainly its wrong as-is, the
implication is that an 8 MB machine would get a max_threads of about 4 :)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Ian Molton <spyro@f2s.com>
--- linux-2.6.15-mm1-full/include/asm-arm26/thread_info.h.old 2006-01-06
16:45:40.000000000 +0100
+++ linux-2.6.15-mm1-full/include/asm-arm26/thread_info.h 2006-01-06
16:46:07.000000000 +0100
@@ -80,8 +80,7 @@
return (struct thread_info *)(sp & ~0x1fff);
}
-/* FIXME - PAGE_SIZE < 32K */
-#define THREAD_SIZE (8*32768) // FIXME - this needs attention (see
kernel/fork.c which gets a nice div by zero if this is lower than 8*32768
+#define THREAD_SIZE PAGE_SIZE
#define task_pt_regs(task) ((struct pt_regs *)(task_stack_page(task) +
THREAD_SIZE - 8) - 1)
extern struct thread_info *alloc_thread_info(struct task_struct *task);
next prev parent reply other threads:[~2006-01-07 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 16:16 [2.6 patch] fix arm26 THREAD_SIZE Adrian Bunk
2006-01-07 0:37 ` Ian Molton [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-09 22:22 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BF0D41.6060003@f2s.com \
--to=spyro@f2s.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox