From: David Vrabel <dvrabel@cantab.net>
To: Thomas Dahlmann <thomas.dahlmann@amd.com>
Cc: Oliver Neukum <oliver@neukum.org>,
linux-usb-devel@lists.sourceforge.net,
Jordan Crouse <jordan.crouse@amd.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
info-linux@ldcmail.amd.com
Subject: Re: [linux-usb-devel] [PATCH] UDC support for MIPS/AU1200 and Geode/CS5536
Date: Tue, 10 Jan 2006 13:16:51 +0000 [thread overview]
Message-ID: <43C3B3C3.6080204@cantab.net> (raw)
In-Reply-To: <43C39431.6020308@amd.com>
Thomas Dahlmann wrote:
>
> The loop is for reading dwords only, so "i < bytes / UDC_DWORD_BYTES" cuts
> off remaining 1,2 or 3 bytes which are handled by the next loop.
> But you are right, incrementing by 4 may look better, as
>
> for (i = 0; i < bytes - bytes % UDC_DWORD_BYTES; i+=4) {
for (i = 0; i <= bytes - UDC_DWORD_BYTES; i += 4) {
?
David Vrabel
next prev parent reply other threads:[~2006-01-10 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060109180356.GA8855@cosmic.amd.com>
2006-01-09 18:21 ` UDC support for MIPS/AU1200 and Geode/CS5536 Jordan Crouse
2006-01-09 22:44 ` [linux-usb-devel] [PATCH] " Oliver Neukum
2006-01-10 11:02 ` Thomas Dahlmann
2006-01-10 13:16 ` David Vrabel [this message]
2006-01-10 13:40 ` Oliver Neukum
2006-01-13 10:08 ` Thomas Dahlmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C3B3C3.6080204@cantab.net \
--to=dvrabel@cantab.net \
--cc=info-linux@ldcmail.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
--cc=thomas.dahlmann@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox