Re: [BUG 2.6.15-git5] new alsa power management completly broken

[Patrizio Bassi <patrizio.bassi@gmail.com>]

Takashi Iwai ha scritto:

>At Tue, 10 Jan 2006 13:02:20 +0100,
>Patrizio Bassi wrote:
>  
>
>>ok i'll test asap. (i think tomorrow).
>>
>>i'll do:
>>1) start pc
>>2) load module and play a wav
>>3) suspend without unloading
>>4) resume (and it shouldn't work)
>>5) unload
>>6) reload and try if that works again (should)
>>
>><joke> blame you, after a report of course. :PPP </joke>
>>    
>>
>
>Any news about blaming or blessing? :)
>
>  
>
>>do you want me to add any debug printk? if so, where? (or post me a patch)
>>    
>>
>
>The patch below might help.  Give it a shot.
>
>
>Takashi
>
>--- a/sound/pci/ens1370.c	7 Dec 2005 11:13:55 -0000	1.91
>+++ b/sound/pci/ens1370.c	10 Jan 2006 16:41:08 -0000
>@@ -2061,6 +2061,13 @@
> #ifdef CHIP1371	
> 	snd_ac97_suspend(ensoniq->u.es1371.ac97);
> #else
>+	/* try to reset AK4531 */
>+	outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x02), ES_REG(ensoniq, 1370_CODEC));
>+	inw(ES_REG(ensoniq, 1370_CODEC));
>+	udelay(100);
>+	outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x03), ES_REG(ensoniq, 1370_CODEC));
>+	inw(ES_REG(ensoniq, 1370_CODEC));
>+	udelay(100);
> 	snd_ak4531_suspend(ensoniq->u.es1370.ak4531);
> #endif	
> 	pci_set_power_state(pci, PCI_D3hot);
>
>  
>

sorry for delay, however i tested it and works perfectly.

just 2 things to notice:
1) [unrelated to this bug] swsusp ram pages write and read is really
slower than 2.6.14 one. i didn't follow changes, so don't know what happened

2) when i suspend i continue to see errors 0x660 in my tty. The strange
thing is that after resume they are no more in dmesg!
strange. however, as i wrote before, it works.

ps. i tested with module only, i'll switch back to built-in solution but
i think there won't be any problems.

big thanks to takashi for patch, please apply.

--
Patrizio Bassi
www.patriziobassi.it