From: Paul Fulghum <paulkf@microgate.com>
To: Jiri Slaby <xslaby@fi.muni.cz>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] synclink_gt fix size of register value storage
Date: Wed, 18 Jan 2006 09:28:29 -0600 [thread overview]
Message-ID: <43CE5E9D.3090707@microgate.com> (raw)
In-Reply-To: <20060118120337.9AB3522B3C4@anxur.fi.muni.cz>
Jiri Slaby wrote:
>>- unsigned char val;
>>+ unsigned short val;
>
> Shouldn't be this u16 rather than ushort?
It could be argued that way.
A quick search of CodingStyle does not
reference the uXX types.
unsigned short is guaranteed to be
at least 16 bits, so no data is lost.
The value is written to the register using
writew(), so no more than 16 bits are used.
Using unsigned short here will always work.
Do you know of a Linux environment where
unsigned short is not 16 bits?
--
Paul Fulghum
Microgate Systems, Ltd.
prev parent reply other threads:[~2006-01-18 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 16:35 [PATCH] synclink_gt fix size of register value storage Paul Fulghum
2006-01-18 12:03 ` Jiri Slaby
2006-01-18 15:28 ` Paul Fulghum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CE5E9D.3090707@microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox