From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linux and Kernel Video <video4linux-list@redhat.com>,
mchehab@infradead.org, linux-dvb-maintainer@linuxtv.org,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH|BUG-FIX] V4L/DVB: allow tristate build for cx88-vp3054-i2c
Date: Mon, 23 Jan 2006 21:55:54 -0500 [thread overview]
Message-ID: <43D5973A.3000103@linuxtv.org> (raw)
In-Reply-To: <20060124001248.GF3590@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
Adrian Bunk wrote:
>On Mon, Jan 23, 2006 at 06:06:28PM -0500, Mike Krufky wrote:
>
>
>>Adrian Bunk wrote:
>>
>>>On Mon, Jan 23, 2006 at 06:24:44PM -0200, mchehab@infradead.org wrote:
>>>
>>>>@@ -70,6 +71,16 @@ config VIDEO_CX88_DVB_MT352
>>>> This adds DVB-T support for cards based on the
>>>> Connexant 2388x chip and the MT352 demodulator.
>>>>
>>>>+config VIDEO_CX88_VP3054
>>>>+ tristate "VP-3054 Secondary I2C Bus Support"
>>>>+ default m
>>>>
>>>This option should be a bool since "m" doesn't make much sense (it's
>>>anyways interpreted the same as "y").
>>>
>>You have a point - it is a boolean choice yes/no, about whether or not
>>to compile support for this module, ... but it is in fact a module, and
>>when M is chosen, cx88-vp3054-i2c.ko will build as a module. When Y is
>>chosen, it will be built in-kernel.
>>
>>
>I don't see this in your patches.
>
>All your patches do is to define -DHAVE_VP3054_I2C=1 depending on
>CONFIG_VIDEO_CX88_VP3054.
>
Oops! I made a mistake, but not the one you thought. The attached
patch fixes it.
Mauro, I just applied this to CVS, please apply on v4l-dvb.git
[PATCH] V4L/DVB: allow tristate build for cx88-vp3054-i2c
- allow tristate build for cx88-vp3054-i2c
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
[-- Attachment #2: cx88-vp3054-i2c-kconfig-fix.patch --]
[-- Type: text/plain, Size: 840 bytes --]
Index: linux/drivers/media/video/cx88/Makefile
===================================================================
RCS file: /cvs/video4linux/v4l-dvb/linux/drivers/media/video/cx88/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- linux/drivers/media/video/cx88/Makefile 21 Jan 2006 17:52:32 -0000 1.8
+++ linux/drivers/media/video/cx88/Makefile 24 Jan 2006 02:41:07 -0000
@@ -4,8 +4,9 @@ cx8800-objs := cx88-video.o cx88-vbi.o
cx8802-objs := cx88-mpeg.o
obj-$(CONFIG_VIDEO_CX88) += cx88xx.o cx8800.o cx8802.o cx88-blackbird.o
-obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o cx88-vp3054-i2c.o
+obj-$(CONFIG_VIDEO_CX88_DVB) += cx88-dvb.o
obj-$(CONFIG_VIDEO_CX88_ALSA) += cx88-alsa.o
+obj-$(CONFIG_VIDEO_CX88_VP3054) += cx88-vp3054-i2c.o
EXTRA_CFLAGS += -I$(src)/..
EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
next prev parent reply other threads:[~2006-01-24 2:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 20:24 [PATCH 00/16] V4L/DVB updates mchehab
2006-01-23 20:24 ` [PATCH 02/16] Add PCI ID for DigitalNow DVB-T Dual, rebranded DViCO FusionHDTV DVB-T Dual mchehab
2006-01-23 20:24 ` [PATCH 03/16] Add probe check for the tda9840 mchehab
2006-01-23 20:24 ` [PATCH 04/16] VIDEO_CX88_ALSA must select SND_PCM mchehab
2006-01-23 20:24 ` [PATCH 01/16] Added credits for em28xx-video.c mchehab
2006-01-23 20:24 ` [PATCH 10/16] make VP-3054 Secondary I2C Bus Support a Kconfig option mchehab
2006-01-23 22:16 ` Adrian Bunk
2006-01-23 23:06 ` Mike Krufky
2006-01-24 0:12 ` Adrian Bunk
2006-01-24 2:55 ` Michael Krufky [this message]
2006-01-26 6:51 ` [PATCH|BUG-FIX] V4L/DVB: allow tristate build for cx88-vp3054-i2c Mauro Carvalho Chehab
2006-01-23 20:24 ` [PATCH 05/16] Fixes tvp5150a/am1 detection mchehab
2006-01-23 20:24 ` [PATCH 07/16] Kill nxt2002 in favor of the nxt200x module mchehab
2006-01-23 20:24 ` [PATCH 08/16] rename dvb_pll_tbmv30111in to dvb_pll_samsung_tbmv mchehab
2006-01-23 20:24 ` [PATCH 09/16] Recognise Hauppauge card #34519 mchehab
2006-01-23 20:24 ` [PATCH 16/16] changed comment in tuner-core.c mchehab
2006-01-23 20:24 ` [PATCH 15/16] Fix printk type warning mchehab
2006-01-23 20:24 ` [PATCH 12/16] drivers/media/dvb/ possible cleanups mchehab
2006-01-23 20:24 ` [PATCH 14/16] fixed spelling error, exectuted --> executed mchehab
2006-01-23 20:24 ` [PATCH 11/16] Cause tda9887 to use I2C_DRIVERID_TDA9887 mchehab
2006-01-23 20:24 ` [PATCH 13/16] Missing break statement on tuner-core mchehab
[not found] ` <200601232155.44036.peter.missel@onlinehome.de>
[not found] ` <1138135687.16005.6.camel@localhost.localdomain>
[not found] ` <200601242159.24747.peter.missel@onlinehome.de>
2006-01-25 11:15 ` [PATCH 06/16] Mark Typhoon cards as Lifeview OEM's Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D5973A.3000103@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox