From: Phillip Susi <psusi@cfl.rr.com>
To: jmerkey@ns1.utah-nac.org
Cc: "linux-os (Dick Johnson)" <linux-os@analogic.com>,
"Jeff V. Merkey" <jmerkey@wolfmountaingroup.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.14 kernels and above copy_to_user stupidity with IRQ disabled check
Date: Fri, 27 Jan 2006 15:39:57 -0500 [thread overview]
Message-ID: <43DA851D.6070209@cfl.rr.com> (raw)
In-Reply-To: <20060127201058.GA18805@ns1.utah-nac.org>
jmerkey@ns1.utah-nac.org wrote:
> OK. Got it. I guess I need to restructure. And BTW, This was a code fragment
> only, the spinlock gets released when -EFAULT is called -- was just an example.
>
> Jeff
Unless you have redefined EFAULT in some strange and hideous way, it is
not "called" and doesn't free the spinlock. EFAULT is defined as a
literal integer, so you're just returning a number without freeing the
spinlock.
If you have redefined EFAULT to a macro function call or whatever, then
don't do that, it's REALLY horrible coding practice.
next prev parent reply other threads:[~2006-01-27 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 18:13 2.6.14 kernels and above copy_to_user stupidity with IRQ disabled check Jeff V. Merkey
2006-01-27 19:30 ` Phillip Susi
2006-01-27 20:18 ` linux-os (Dick Johnson)
2006-01-27 20:10 ` jmerkey
2006-01-27 20:22 ` jmerkey
2006-01-27 20:39 ` Phillip Susi [this message]
2006-01-27 19:28 ` Jeff V. Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DA851D.6070209@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=jmerkey@ns1.utah-nac.org \
--cc=jmerkey@wolfmountaingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox