From: Zach Brown <zach.brown@oracle.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [x86-64] align per-cpu section to configured cache bytes
Date: Fri, 27 Jan 2006 15:45:48 -0800 [thread overview]
Message-ID: <43DAB0AC.9010108@oracle.com> (raw)
In-Reply-To: <20060127233227.GA9274@mars.ravnborg.org>
Sam Ravnborg wrote:
> On Fri, Jan 27, 2006 at 02:02:42PM -0800, Zach Brown wrote:
>
>>- . = ALIGN(32);
>>+ . = ALIGN(CONFIG_X86_L1_CACHE_BYTES);
>
>
> Grepping other arch's than just x86 and x86_64 it looks like a common
> thing.
> Is this fix really only relevant for x86 + x86_64 or should it be done
> for all arch's?
I think it'd be needed if other archs had situations where C's
(load_module()'s, in particular) notion of the cacheline size differed
from vmlinux.lds.S's. I didn't want to go screwing around with archs
that I couldn't immediately test :)
> If we do it for all archs we may as well create:
> #define PERCPU(aling) ...
> macro in asm-generic/vmlinux.lds.h
Sounds reasonable to me, should I leave that in your capable hands?
- z
next prev parent reply other threads:[~2006-01-27 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 22:02 [PATCH 1/2] [x86-64] align per-cpu section to configured cache bytes Zach Brown
2006-01-27 22:02 ` [PATCH 2/2] [x86] " Zach Brown
2006-01-28 21:26 ` Sam Ravnborg
2006-01-27 23:32 ` [PATCH 1/2] [x86-64] " Sam Ravnborg
2006-01-27 23:45 ` Zach Brown [this message]
2006-01-28 3:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DAB0AC.9010108@oracle.com \
--to=zach.brown@oracle.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox