From: "Antonino A. Daplas" <adaplas@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: benh@kernel.crashing.org, linux-kernel@hansmi.ch,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] framebuffer: Remove old radeon driver
Date: Sat, 28 Jan 2006 13:59:21 +0800 [thread overview]
Message-ID: <43DB0839.6010703@gmail.com> (raw)
In-Reply-To: <20060127.204645.96477793.davem@davemloft.net>
David S. Miller wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Sat, 28 Jan 2006 15:09:52 +1100
>
>> On Sat, 2006-01-28 at 00:13 +0100, Michael Hanselmann wrote:
>
> The radeon_screen_blank() routine returns error codes back
> to the X server which handily confuses it, making it
> impossible to unblank the screen unless X has taken it
> all the way to power-off or somesuch. The comment above
> this problematic code states:
>
> /* let fbcon do a soft blank for us */
> return (blank == FB_BLANK_NORMAL) ? -EINVAL : 0;
>
> There has to be a better way to do this, which doesn't break
> X when run via fbcon. :-)
>
The console layer has 5 blanking levels, with FB_BLANK_NORMAL defined
as "soft blank" (or blank the display without turning off display sync
signals) -- a console invention. However, VESA has only 4 levels.
This can be easily fixed by incrementing the blank value by one if
the request originated from userspace. I'll provide a patch
soon.
Tony
next prev parent reply other threads:[~2006-01-28 5:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 23:13 [PATCH] framebuffer: Remove old radeon driver Michael Hanselmann
2006-01-28 4:09 ` Benjamin Herrenschmidt
2006-01-28 4:46 ` David S. Miller
2006-01-28 5:59 ` Antonino A. Daplas [this message]
2006-01-28 20:06 ` Ingo Oeser
2006-01-29 2:18 ` [PATCH] fbdev: Fix usage of blank value passed to fb_blank Antonino A. Daplas
2006-01-29 8:18 ` Andrew Morton
2006-01-29 10:40 ` Antonino A. Daplas
2006-01-29 14:42 ` [Linux-fbdev-devel] " Ville Syrjälä
2006-01-29 22:19 ` Antonino A. Daplas
2006-01-29 23:34 ` Antonino A. Daplas
2006-01-30 10:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DB0839.6010703@gmail.com \
--to=adaplas@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox