public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuki Cuss <celtic@sairyx.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pid: Don't hash pid 0.
Date: Mon, 30 Jan 2006 20:44:41 +1100	[thread overview]
Message-ID: <43DDE009.9090104@sairyx.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0601301028510.6405@yvahk01.tjqt.qr>

Jan Engelhardt wrote:

>>@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en
>>{
>>	struct pid *pid, *task_pid;
>>
>>+	if (!nr)
>>+		goto out;
>>+
>>    
>>
>
>How about nr==0, it would make it more obvious.
>
>
>
>Jan Engelhardt
>  
>

I am inclined to agree. `!nr' seems to imply some sort of an error 
condition; perhaps a comment could be placed in order to make why the 
case of (nr == 0) is being ignored.

 - Yuki.

  reply	other threads:[~2006-01-30  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-29  6:31 [PATCH] pid: Don't hash pid 0 Eric W. Biederman
2006-01-29  8:33 ` Andrew Morton
2006-01-29 10:04   ` Eric W. Biederman
2006-01-30  9:29 ` Jan Engelhardt
2006-01-30  9:44   ` Yuki Cuss [this message]
2006-01-30  9:49     ` Jan Engelhardt
2006-01-30  9:58       ` Nigel Cunningham
  -- strict thread matches above, loose matches on Subject: below --
2006-01-30 10:59 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43DDE009.9090104@sairyx.org \
    --to=celtic@sairyx.org \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox