From: Kirill Korotaev <dev@sw.ru>
To: Jan Blunck <jblunck@suse.de>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
olh@suse.de, balbir@in.ibm.com
Subject: Re: [PATCH] shrink_dcache_parent() races against shrink_dcache_memory()
Date: Mon, 30 Jan 2006 18:59:01 +0300 [thread overview]
Message-ID: <43DE37C5.30003@sw.ru> (raw)
In-Reply-To: <20060130145859.GG9181@hasse.suse.de>
Hello Jan,
>>
>>this is much cleaner now and looks more like my original patch and is
>>smaller/more beautifull with counters usage. Thanks.
>
>
> Yes, it is heavily inspired by you patch.
thanks again. BTW, out of curiosity why do you work on this?
>>However, with counters instead of list it is possible to create a live
>>lock :( So I'm not sure it is really ok.
>
>
> Hmm, I don't really get what you mean with "live lock".
By "live lock" I mean the situation when you are "locked" in
shrink_dcache_parent() due to wait_on_prunes() always returns 1.
We used shrinker list with a reference to dentry specially to avoid this
as much as possible. I'm not sure how real such live lock can be
created, but I can think it over.
>>BTW, what kernel is it for? 2.6.15 or 2.6.16-X?
>
>
> http://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git from
> today.
thanks!
Kirill
prev parent reply other threads:[~2006-01-30 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 20:36 [PATCH] shrink_dcache_parent() races against shrink_dcache_memory() Jan Blunck
2006-01-23 5:22 ` Andrew Morton
2006-01-23 8:12 ` Kirill Korotaev
2006-01-23 15:13 ` Jan Blunck
2006-01-23 8:07 ` Kirill Korotaev
2006-01-23 15:57 ` Jan Blunck
2006-01-24 5:54 ` Balbir Singh
2006-01-24 9:48 ` Kirill Korotaev
2006-01-24 11:10 ` Balbir Singh
2006-01-24 17:18 ` Kirill Korotaev
2006-01-25 7:03 ` Balbir Singh
2006-01-30 12:03 ` Jan Blunck
2006-01-30 14:38 ` Balbir Singh
2006-01-30 14:54 ` Jan Blunck
2006-01-30 15:02 ` Kirill Korotaev
2006-01-30 15:25 ` Jan Blunck
2006-01-30 15:31 ` Kirill Korotaev
2006-01-30 14:42 ` Kirill Korotaev
2006-01-30 14:58 ` Jan Blunck
2006-01-30 15:59 ` Kirill Korotaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DE37C5.30003@sw.ru \
--to=dev@sw.ru \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox