From: "Jan Beulich" <JBeulich@novell.com>
To: "Dave Jones" <davej@redhat.com>, "Andi Kleen" <ak@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] prevent nested panic from soft lockup detection
Date: Tue, 31 Jan 2006 14:46:51 +0100 [thread overview]
Message-ID: <43DF785B.76F0.0078.0@novell.com> (raw)
In-Reply-To: <p73fyn4mv7d.fsf@verdi.suse.de>
>> I've been wondering for a while why we don't just make touch_nmi_watchdog
>> do an implicit call to touch_softlockup_watchdog. I can't think of a situation
>> where we'd want to do one but not the other, and adding patches like this
>> seems to be an uphill battle (I know at least two other places that need
>> this off the top of my head).
>
>Very good idea.
>
>Someone did it already in the SUSE kernel and it helped considerably
>there.
Actually, plain 2.6.15 already has this (for i386 and x86-64 at least). Hence the first of the two hunks the patch
consists of is superfluous. The second hunk, however, is still necessary (as there's no pre-existing
touch_nmi_watchdog() call there, and there also shouldn't be one as interrupts get re-enabled before getting there).
Jan
next prev parent reply other threads:[~2006-01-31 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <43DDE5A1.76F0.0078.0@novell.com.suse.lists.linux.kernel>
[not found] ` <20060130145850.GB9752@redhat.com.suse.lists.linux.kernel>
2006-01-31 12:35 ` [PATCH] prevent nested panic from soft lockup detection Andi Kleen
2006-01-31 13:46 ` Jan Beulich [this message]
2006-01-30 9:08 Jan Beulich
2006-01-30 14:58 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DF785B.76F0.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox