From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Williams <pwil3058@bigpond.net.au>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Avoid moving tasks when a schedule can be made.
Date: Thu, 02 Feb 2006 00:10:26 +1100 [thread overview]
Message-ID: <43E0B342.6090700@yahoo.com.au> (raw)
In-Reply-To: <43E0B24E.8080508@yahoo.com.au>
Nick Piggin wrote:
> Steven Rostedt wrote:
>
>>
>> No real work is lost. This is a loop that individually pulls tasks. So
>> the bail only stops the work of looking for more tasks to pull and we
>> don't lose the tasks that have already been pulled.
>>
>>
>
> Once we've gone to the trouble of deciding which tasks to move and how
> many (and the estimate should be very conservative), and locked the source
> and destination runqueues, it is a very good idea to follow up with our
> threat of actually moving the tasks rather than bail out early.
>
Oh, I forgot: Ingo once introduced some code to bail early (though for
different reasons and under different conditions), and this actually
was found to cause significant regressions in some database workloads.
So it is not a nice thing to tinker with unless there is good reason.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-02-01 13:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 19:43 [PATCH] Avoid moving tasks when a schedule can be made Steven Rostedt
2006-02-01 3:36 ` Peter Williams
2006-02-01 12:44 ` Steven Rostedt
2006-02-01 13:06 ` Nick Piggin
2006-02-01 13:10 ` Nick Piggin [this message]
2006-02-01 13:20 ` Ingo Molnar
2006-02-01 13:47 ` Nick Piggin
2006-02-01 13:54 ` Nick Piggin
2006-02-01 14:12 ` Ingo Molnar
2006-02-01 14:25 ` Nick Piggin
2006-02-01 14:37 ` Ingo Molnar
2006-02-01 14:54 ` Nick Piggin
2006-02-01 15:11 ` Ingo Molnar
2006-02-01 15:31 ` Nick Piggin
2006-02-01 16:10 ` Ingo Molnar
2006-02-01 16:25 ` Nick Piggin
2006-02-01 17:24 ` Ingo Molnar
2006-02-06 11:21 ` Nick Piggin
2006-02-01 14:00 ` Ingo Molnar
2006-02-01 14:09 ` Nick Piggin
2006-02-01 14:22 ` Ingo Molnar
2006-02-01 14:32 ` Steven Rostedt
2006-02-02 1:26 ` Peter Williams
2006-02-02 2:48 ` Steven Rostedt
2006-02-02 3:19 ` Peter Williams
2006-02-01 13:08 ` Ingo Molnar
2006-02-01 13:11 ` Ingo Molnar
2006-02-02 1:42 ` Peter Williams
2006-02-02 2:51 ` Steven Rostedt
2006-02-01 13:15 ` Steven Rostedt
2006-02-01 13:23 ` Steven Rostedt
2006-02-01 13:26 ` Ingo Molnar
2006-02-01 16:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E0B342.6090700@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pwil3058@bigpond.net.au \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox