From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Tony Lindgren <tony@atomide.com>,
Anderson Briglia <anderson.briglia@indt.org.br>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/5] MMC OMAP driver
Date: Thu, 02 Feb 2006 12:45:55 +0100 [thread overview]
Message-ID: <43E1F0F3.3020801@drzeus.cx> (raw)
In-Reply-To: <20060202104022.GF5034@flint.arm.linux.org.uk>
Russell King wrote:
> Here's a revised patch. Pierre - could you look at the missing command
> types marked with /* ? */ in this patch please?
>
>
*snip*
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -211,7 +211,7 @@ int mmc_wait_for_app_cmd(struct mmc_host
>
> appcmd.opcode = MMC_APP_CMD;
> appcmd.arg = rca << 16;
> - appcmd.flags = MMC_RSP_R1;
> + appcmd.flags = MMC_RSP_R1 | MMC_CMD_AC; /* ? */
> appcmd.retries = 0;
> memset(appcmd.resp, 0, sizeof(appcmd.resp));
> appcmd.data = NULL;
>
Correct.
> @@ -358,7 +358,7 @@ static int mmc_select_card(struct mmc_ho
> struct mmc_command cmd;
> cmd.opcode = SD_APP_SET_BUS_WIDTH;
> cmd.arg = SD_BUS_WIDTH_4;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1; /* ? */
>
> err = mmc_wait_for_app_cmd(host, card->rca, &cmd,
> CMD_RETRIES);
>
MMC_CMD_AC
> @@ -766,7 +766,7 @@ static int mmc_send_app_op_cond(struct m
>
> cmd.opcode = SD_APP_OP_COND;
> cmd.arg = ocr;
> - cmd.flags = MMC_RSP_R3;
> + cmd.flags = MMC_RSP_R3; /* ? */
>
> for (i = 100; i; i--) {
> err = mmc_wait_for_app_cmd(host, 0, &cmd, CMD_RETRIES);
>
MMC_CMD_BCR
> @@ -835,7 +835,7 @@ static void mmc_discover_cards(struct mm
>
> cmd.opcode = SD_SEND_RELATIVE_ADDR;
> cmd.arg = 0;
> - cmd.flags = MMC_RSP_R6;
> + cmd.flags = MMC_RSP_R6; /* ? */
>
> err = mmc_wait_for_cmd(host, &cmd, CMD_RETRIES);
> if (err != MMC_ERR_NONE)
>
MMC_CMD_BCR (feel free to update protocol.h since it's incorrect with
regard to this opcode)
> @@ -920,7 +920,7 @@ static void mmc_read_scrs(struct mmc_hos
>
> cmd.opcode = MMC_APP_CMD;
> cmd.arg = card->rca << 16;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1 | MMC_CMD_AC; /* ? */
>
> err = mmc_wait_for_cmd(host, &cmd, 0);
> if ((err != MMC_ERR_NONE) || !(cmd.resp[0] & R1_APP_CMD)) {
>
Correct.
> @@ -932,7 +932,7 @@ static void mmc_read_scrs(struct mmc_hos
>
> cmd.opcode = SD_APP_SEND_SCR;
> cmd.arg = 0;
> - cmd.flags = MMC_RSP_R1;
> + cmd.flags = MMC_RSP_R1; /* ? */
>
> memset(&data, 0, sizeof(struct mmc_data));
>
MMC_CMD_ADTC
Rgds
Pierre
next prev parent reply other threads:[~2006-02-02 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:34 [patch 1/5] MMC OMAP driver Anderson Briglia
2006-01-31 15:29 ` Pierre Ossman
2006-02-01 12:44 ` Russell King
2006-02-01 19:47 ` Tony Lindgren
2006-02-02 10:40 ` Russell King
2006-02-02 11:45 ` Pierre Ossman [this message]
2006-02-02 12:24 ` Russell King
2006-02-17 19:53 ` Carlos Aguiar
2006-02-17 20:08 ` Russell King
2006-02-02 19:34 ` Anderson Briglia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E1F0F3.3020801@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=anderson.briglia@indt.org.br \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox