public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Haren Myneni <haren@us.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org,
	Fastboot mailing list <fastboot@lists.osdl.org>,
	linuxppc64-dev@ozlabs.org, Milton Miller <miltonm@bga.com>,
	hpa@zytor.com
Subject: Re: [PATCH] Fix in free initrd when overlapped with crashkernel region
Date: Tue, 07 Feb 2006 15:01:30 -0800	[thread overview]
Message-ID: <43E926CA.3000601@us.ibm.com> (raw)
In-Reply-To: <17384.24235.960221.979322@cargo.ozlabs.ibm.com>

Paul Mackerras wrote:

>Haren Myneni writes:
>
>  
>
>>--- 2616-rc2.orig/include/linux/kexec.h	2006-02-06 19:08:01.000000000 -0800
>>+++ 2616-rc2/include/linux/kexec.h	2006-02-06 19:06:37.000000000 -0800
>>@@ -6,6 +6,7 @@
>> #include <linux/list.h>
>> #include <linux/linkage.h>
>> #include <linux/compat.h>
>>+#include <linux/ioport.h>
>> #include <asm/kexec.h>
>>    
>>
>
>What's this hunk for?
>
>Paul.
>  
>

crashk_res is an extern declaration in kexec.h. Declared as "struct 
resource" which is defined in linux/ioport.h.
For other places wherever this variable is used, ioport.h got included 
through some other header file.  Whereas for initramfs.c, either we need 
to include ioport.h explicitly or include in kexec.h. Chosen the later 
one. Probably, some comment would be better to make it clear.

Paul, do you prefer to repost the patch with the comment?

Thanks
Haren

>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>
>  
>


      reply	other threads:[~2006-02-07 23:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-07  3:50 [PATCH] Fix in free initrd when overlapped with crashkernel region Haren Myneni
2006-02-07  8:47 ` Paul Mackerras
2006-02-07 23:01   ` Haren Myneni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E926CA.3000601@us.ibm.com \
    --to=haren@us.ibm.com \
    --cc=fastboot@lists.osdl.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox